Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Combine initialization #18

Merged
merged 3 commits into from
Aug 24, 2023
Merged

Conversation

Maksimka101
Copy link
Owner

@Maksimka101 Maksimka101 commented Aug 24, 2023

Did the following fixes:

  • the BackgroundIsolateBinaryMessenger initialization

PR Checklist

  • Code is 100% covered.
  • I updated/added relevant documentation.
  • All existing and new tests are passing.
  • Changelog is updated.
  • Version is pumped

@codecov-commenter
Copy link

Codecov Report

Merging #18 (c383946) into master (24188b0) will not change coverage.
Report is 1 commits behind head on master.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff            @@
##            master       #18   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           30        28    -2     
  Lines          383       381    -2     
=========================================
- Hits           383       381    -2     
Files Changed Coverage Δ
...indings/mock_binary_messenger_service_binding.dart 100.00% <100.00%> (ø)
...ib/src/isolate_factory/native_isolate_factory.dart 100.00% <100.00%> (ø)

@Maksimka101 Maksimka101 merged commit dcd7d09 into master Aug 24, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants