Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Belarusian translation. #3207

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

spoooyders
Copy link

@spoooyders spoooyders commented Mar 26, 2024

What type of PR?

Translation.

What does this PR do?

Adds Belarusian translation.

Related issue(s)

Prerequisites

Before we can consider review and merge, please make sure the following list is done and checked.
If an entry in not applicable, you can check it or remove it from the list.

  • In case of feature or enhancement: documentation updated accordingly
  • Unless it's docs or a minor change: add changelog entry file.

Copy link
Contributor

mergify bot commented Mar 26, 2024

Thanks for submitting this pull request.
Bors-ng will now build test images. When it succeeds, we will continue to review and test your PR.

bors try

Note: if this build fails, read this.

bors-mailu bot added a commit that referenced this pull request Mar 26, 2024
@bors-mailu
Copy link
Contributor

bors-mailu bot commented Mar 26, 2024

try

Build succeeded:

@spoooyders
Copy link
Author

Ok, now I think it is finally ready and correct. Please review.

@Diman0
Copy link
Member

Diman0 commented Mar 26, 2024

bors try

bors-mailu bot added a commit that referenced this pull request Mar 26, 2024
@bors-mailu
Copy link
Contributor

bors-mailu bot commented Mar 26, 2024

try

Build succeeded:

Copy link
Member

@Diman0 Diman0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. Can you also add a translation for the text string Current password?

current_pw = fields.PasswordField(_('Current password'), [validators.DataRequired()])

https://github.com/Mailu/Mailu/blob/master/core/admin/mailu/ui/templates/user/password.html

This text string is shown on the password update page. The URL for accessing this page is:
https://myhostname.com/myuser(thelocalpart)/user/password
E.g. if your login is [email protected] and the hostname is mailu.io:
https://mailu.io/example/user/password

Diman0
Diman0 previously requested changes Mar 27, 2024
Copy link
Member

@Diman0 Diman0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same applies for the text string Download zonefile

</a><a style="margin-right: 5px;" class="btn btn-primary btn-group float-right" href="{{ url_for(".domain_download_zonefile", domain_name=domain.name) }}"> {% trans %}Download zonefile{% endtrans %}</a>

This string is used on the Domain details page:
https://example.com/admin/domain/details/mailu.io
where mailu.io is the mail domain

@Diman0
Copy link
Member

Diman0 commented Mar 27, 2024

Both untranslated text strings are new in the upcoming release and have not been translated yet in any of the other languages. That is why you missed these.

@Diman0
Copy link
Member

Diman0 commented Mar 27, 2024

On the user edit page (https://example.com/admin/user/edit/[email protected]) you are also missing the translations for:

  • Force password change at next login
  • Allow the user to spoof the sender (send email as anyone)

You can translate the earlier mentioned missing translations via:

#: mailu/ui/templates/domain/details.html:19
msgid "Download zonefile"
msgstr "translation of Download zonefile"

#: mailu/ui/forms.py:134
msgid "Current password"
msgstr "translation of Current password"

#: mailu/ui/forms.py:102
msgid "Force password change at next login"
msgstr "translation of Allow the user to spoof the sender (send email as anyone)"

#: mailu/ui/forms.py:98
msgid "Allow the user to spoof the sender (send email as anyone)"
msgstr "translation of Allow the user to spoof the sender (send email as anyone)"

@mergify mergify bot dismissed Diman0’s stale review March 30, 2024 10:47

Pull request has been modified.

@spoooyders
Copy link
Author

Ok, tried to add them. Also added translation for a note about Apple autoconfig.

Not sure how to get an image to test it all - do I need to post bors try for it to build? Or does only maintainers have permissions to build?...

Anyways, @Diman0 please take another look.

@Diman0
Copy link
Member

Diman0 commented Mar 30, 2024

You are correct. Only maintainers can trigger a build. You can test the new build using tag pr-3207
Ghcr.io/Mailu/admin:pr3207

Bors try

bors-mailu bot added a commit that referenced this pull request Mar 30, 2024
@bors-mailu
Copy link
Contributor

bors-mailu bot commented Mar 30, 2024

try

Build succeeded:

@spoooyders
Copy link
Author

@Diman0 I verified it, everything looks good.

@Diman0
Copy link
Member

Diman0 commented Apr 2, 2024

@Diman0 I verified it, everything looks good.

Thank you for the confirmation. It also looks good to me. At least that the interface is translated to a different language than English. I don't speak Belarusian so I trust the translation is correct.

Copy link
Member

@Diman0 Diman0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Diman0 Diman0 added this to the 2024.x milestone Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants