Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow PROXY_PROTOCOL to be per-port customizable. #3061

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alex4108
Copy link

@alex4108 alex4108 commented Nov 18, 2023

What type of PR?

Enhancement

What does this PR do?

Allow PROXY_PROTOCOL env variable to be set on only a specific port. Eg, in my case, only tcp/25 needs to have PROXY_PROTOCOL enabled.

Prerequisites

Before we can consider review and merge, please make sure the following list is done and checked.
If an entry in not applicable, you can check it or remove it from the list.

  • [ x ] In case of feature or enhancement: documentation updated accordingly
  • Unless it's docs or a minor change: add changelog entry file.

Copy link
Contributor

mergify bot commented Nov 18, 2023

Thanks for submitting this pull request.
Bors-ng will now build test images. When it succeeds, we will continue to review and test your PR.

bors try

Note: if this build fails, read this.

bors-mailu bot added a commit that referenced this pull request Nov 18, 2023
@bors-mailu
Copy link
Contributor

bors-mailu bot commented Nov 18, 2023

try

Build succeeded:

Copy link
Contributor

@nextgens nextgens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is something we want (in general): without documentation it's worthless and making good documentation about it is complex.

I also fail to see why we wouldn't go the extra mile and allow PROXY_PROTOCOL to be a comma separated list of ports we'd allow if we go down that route.

* ``pop3`` to accept the ``PROXY`` protocol on TCP 110 only
* ``submissions`` to accept the ``PROXY`` protocol on TCP 465 only
* ``submission`` to accept the ``PROXY`` protocol on TCP 587 only
* ``smtp`` to accept the ``PROXY`` protocol on TCP 995 only
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* ``smtp`` to accept the ``PROXY`` protocol on TCP 995 only
* ``pop3s`` to accept the ``PROXY`` protocol on TCP 995 only

@nextgens
Copy link
Contributor

#3060 was asking for something similar

Copy link
Contributor

mergify bot commented Feb 22, 2024

Thanks for submitting this pull request.
Bors-ng will now build test images. When it succeeds, we will continue to review and test your PR.

bors try

Note: if this build fails, read this.

bors-mailu bot added a commit that referenced this pull request Feb 29, 2024
@bors-mailu
Copy link
Contributor

bors-mailu bot commented Feb 29, 2024

try

Build succeeded:

@nextgens nextgens mentioned this pull request Apr 8, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants