New feature: blog #103
Draft
New feature: blog #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinbeaty
reviewed
Feb 6, 2025
fballiano
commented
Feb 6, 2025
Comment on lines
16
to
25
| /* | ||
| $installer->getConnection()->query('drop table blog_post_entity'); | ||
| $installer->getConnection()->query('drop table blog_post_entity_char'); | ||
| $installer->getConnection()->query('drop table blog_post_entity_datetime'); | ||
| $installer->getConnection()->query('drop table blog_post_entity_decimal'); | ||
| $installer->getConnection()->query('drop table blog_post_entity_int'); | ||
| $installer->getConnection()->query('drop table blog_post_entity_text'); | ||
| $installer->getConnection()->query('drop table blog_post_entity_varchar'); | ||
| $installer->getConnection()->query('delete from eav_entity_type where entity_type_code="blog_post"'); | ||
| */ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is far from being testable but I wanted to have it here already.
The nice thing of this implementation is that it's all built on EAV, instead of a static table like all the modules from the past.
TODO
QUESTIONS: