Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make prepare() not use named statements by default when cache is disabled #1245

Merged
merged 1 commit into from
Mar 19, 2025

Conversation

elprans
Copy link
Member

@elprans elprans commented Mar 16, 2025

We allow disabling the statement cache to circumvent a proxy's inability to
cope with them, however there are still some holes where the use of a named
statement is attempted: prepare() with the default arguments, and
copy_in(). Fix both so that the use of a named statement is dependent
upon whether the prepared statement cache is enabled.

Fixes: #1219
Closes: #1218

…sabled

We allow disabling the statement cache to circumvent a proxy's inability to
cope with them, however there are still some holes where the use of a named
statement is attempted: `prepare()` with the default arguments, and
`copy_in()`.  Fix both so that the use of a named statement is dependent
upon whether the prepared statement cache is enabled.

Fixes: #1219
Closes: #1218
@elprans elprans merged commit 5b14653 into master Mar 19, 2025
41 checks passed
@elprans elprans deleted the named-ps branch March 19, 2025 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

copy_records_to_table uses named prepared statement even when statement_cache_size is 0
1 participant