Implement connection service file functionality #1223
+258
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elprans
reviewed
Mar 19, 2025
elprans
reviewed
Mar 19, 2025
Co-authored-by: Elvis Pranskevichus <[email protected]>
elprans
reviewed
Mar 20, 2025
|
Another complication wrt the connection service functionality: apparently connection service files also allow ldap lookups. |
elprans
reviewed
Mar 21, 2025
Co-authored-by: Elvis Pranskevichus <[email protected]>
|
I believe the test failure is due to a flaky test. Please let me know if there are any other changes that need to be made to this PR. |
elprans
reviewed
Mar 26, 2025
| if ssl is None: | ||
| ssl = val | ||
|
|
||
| if 'sslcert' in service_params: |
There was a problem hiding this comment.
This and other ssl params below are missing the if <param> is None: check.
added 2 commits
March 26, 2025 13:44
elprans
reviewed
Mar 26, 2025
| @@ -2074,6 +2074,7 @@ async def _do_execute( | |||
| async def connect(dsn=None, *, | |||
| host=None, port=None, | |||
| user=None, password=None, passfile=None, | |||
| service=None, | |||
There was a problem hiding this comment.
Oh, I think we should also let you specify the service file location via the servicefile kwarg (a-la passfile).
There was a problem hiding this comment.
Also please add a .. versionadded:: 0.31.0 tag in the docstring below mentioning the new kwargs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to implement connection service file functionality into asyncpg.
Connection service files are a libpq feature that allows details of postgres connection strings to be stored in a file that is referenced via a
serviceparameter in the connection string. This makes it very easy to ensure/enforce consistent connection strings across a codebase.https://www.postgresql.org/docs/17/libpq-pgservice.html