Check config before starting MM

[KristjanESPERANTO]

I think it might be a good idea to check the config at every start.

[khassel]

We implemented the possibility to use a config.js.template instead of a config.js (where the config.js is created while startup).

At the moment the check fails if there is no config.js:

[2024-05-14 21:51:17.549] [ERROR] File not found: /opt/magic_mirror/config/config.js

So if we want this check the code must be changed that no error is thrown if no config.js exists but a config.js.template.
If we want to check config.js.template in such a case I don't now if the check can handle Variables ${XY} which can be present in config.js.template. There is also a env variable MM_CONFIG_FILE which is used to set another config file location. I don't know if the check respects this variable (it should).

Other point: Any idea why the test fails?

[bugsounet]

Why not hard coding this check in main core of MM² before loading config ?

in this case, it's +/- related to #3445

[sdetweil]

in general I am in favor of not starting if there is a fatal config error .

not like now where we start with a built in dummy config, unlike whatever the user expected.

[khassel]

I agree with the idea, I just wanted to point out that the current approach doesn't fit all use cases...

Why not hard coding this check in main core of MM² before loading config ?

I think loadConfig in app.js must be executed before the check because in this function the config.js is created when using config.js.template.

[KristjanESPERANTO]

I'd like to take a closer look, but it looks like I will not find the time soon.