Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(control_history): change depth history to 56 days #476

Merged

Conversation

gaspard-lonchampt
Copy link
Contributor

@gaspard-lonchampt gaspard-lonchampt commented Dec 19, 2024

⚠️ Variable d'environnement à mettre pour la MEP : USER_CONTROL_HISTORY_DEPTH=56

PR FRONT

https://trello.com/c/DV54hcgG/1670-faire-passer-le-nombre-de-jours-contr%C3%B4l%C3%A9s-%C3%A0-56

@gaspard-lonchampt gaspard-lonchampt force-pushed the feat/control_history_change_depth_history_to_56_days branch from ea2ccae to 7b0e9b2 Compare December 19, 2024 10:42
Copy link
Contributor

@sandrica89 sandrica89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corriger le test qui fail

config.py Outdated Show resolved Hide resolved
app/tests/regulations/test_report_infractions.py Outdated Show resolved Hide resolved
@gaspard-lonchampt
Copy link
Contributor Author

Corriger le test qui fail

J'ai corrigé, dans le test on vérifie qu'on a bien un jour en faisant 1 jour avant et 30 jours avant, et vu que la fenêtre de temps 'history_start_date' est élargi à 56 jours, on a bien deux jours. Du coup j'ai augmenté à 60 jours avant pour que le test reste cohérent.

@tristan-gueguen tristan-gueguen merged commit f9e3a5e into master Jan 2, 2025
8 checks passed
@tristan-gueguen tristan-gueguen deleted the feat/control_history_change_depth_history_to_56_days branch January 2, 2025 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants