fix(authentification): delete all refresh token #475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaspard-lonchampt
force-pushed
the
fix/delete_all_refresh_token
branch
from
a521603 to
cb2fef0
Compare
|
tristan-gueguen
approved these changes
Dec 17, 2024
| token=identity.get("token"), | ||
| controller_user_id=identity.get("controllerUserId"), | ||
| ) | ||
| delete_controller_refresh_token() |
There was a problem hiding this comment.
🔴 cette fonction supprime le token controller mais l'éxécution continue après, est-ce que ce n'est pas un problème ? la ligne 417 ne va pas provoquer une erreur ? et la ligne 423 (on n'aura pas set user_id)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal to fix refresh token error : https://trello.com/c/PMRGH2i8/1461