Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vérifie si le linéaire est présent dans le périmètre de l'organisation #1246

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mmarchois
Copy link
Collaborator

@mmarchois mmarchois commented Mar 17, 2025

Cette PR permet de restreindre la saisie d'une localisation au périmètre de son organisation compétente.

brave_screenshot_localhost (1)

@mmarchois mmarchois self-assigned this Mar 17, 2025
@codecov-commenter
Copy link

codecov-commenter commented Mar 17, 2025

Codecov Report

Attention: Patch coverage is 42.85714% with 12 lines in your changes missing coverage. Please review.

Project coverage is 98.23%. Comparing base (75fb6bc) to head (7b59ee9).

Files with missing lines Patch % Lines
...Repository/Organization/OrganizationRepository.php 0.00% 12 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1246      +/-   ##
============================================
- Coverage     98.35%   98.23%   -0.13%     
- Complexity     2133     2138       +5     
============================================
  Files           435      436       +1     
  Lines          9200     9221      +21     
============================================
+ Hits           9049     9058       +9     
- Misses          151      163      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mmarchois mmarchois force-pushed the feat/can-organization-intervene-on-geometry branch 2 times, most recently from 3ff4b71 to cae5b06 Compare March 17, 2025 16:17
@mmarchois
Copy link
Collaborator Author

mmarchois commented Mar 18, 2025

@Lealefoulon merci pour la review, je vais rajouter quelques tests :)

@mmarchois mmarchois force-pushed the feat/can-organization-intervene-on-geometry branch 7 times, most recently from 44af1d1 to 6a4cf03 Compare March 19, 2025 09:34
@mmarchois mmarchois force-pushed the feat/can-organization-intervene-on-geometry branch from 6a4cf03 to 01c23f9 Compare March 19, 2025 10:13
@Lealefoulon Lealefoulon self-requested a review March 20, 2025 15:23
Copy link

gitguardian bot commented Mar 24, 2025

⚠️ GitGuardian has uncovered 3 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
16117795 Triggered Generic Password 886771e src/Infrastructure/Persistence/Doctrine/Fixtures/UserFixture.php View secret
16117796 Triggered Generic Password 886771e src/Infrastructure/Persistence/Doctrine/Fixtures/UserFixture.php View secret
16117797 Triggered Generic Password 886771e src/Infrastructure/Persistence/Doctrine/Fixtures/UserFixture.php View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@mmarchois mmarchois force-pushed the feat/can-organization-intervene-on-geometry branch 2 times, most recently from 3dc9542 to d9df538 Compare March 24, 2025 15:00
@mmarchois mmarchois force-pushed the feat/can-organization-intervene-on-geometry branch from d9df538 to 886771e Compare March 24, 2025 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants