add a new stream property 'gattr_update' to control whether to update global attributes #1368
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we do coldstart data assimilation on
init.ncusing JEDI, we will get a crash in MPAS IO with the following error:Per discussions with NOAA @SamuelTrahanNOAA and NCAR Tao Sun, we identified that the problem came from
src/framework/mpas_stream_manager.Fwherempas_writeStreamAtttries to write not-defined global attributes toinit.nc. Since we don't expect JEDI to update any global attributes (at least forinit.nc), we can skip the relevantmpas_writeStreamAttpart when doing JEDI data assimilation.This PR is to address this issue by adding a new stream property
gattr_update. It takes values ofyesornoand defaults toyes. So it does not affect any existing MPAS-Model capabilities but allow coldstart JEDI DA to skip the relevantmpas_writeStreamAttpart to avoid crash, by settinggattr_update=noin theanalysisstream.