Skip to content

TIMX 496- Update TDA library #364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 3, 2025
Merged

TIMX 496- Update TDA library #364

merged 2 commits into from
Jun 3, 2025

Conversation

ghukill
Copy link
Contributor

@ghukill ghukill commented Jun 3, 2025

Purpose and background context

This PR explicitly updates the TDA library when make update is called.

Includes new or updated dependencies?

YES

Changes expectations for external applications?

YES: Transmogrifier will not start writing a run_timestamp column to the dataset.

What are the relevant tickets?

Developer

  • All new ENV is documented in README
  • All new ENV has been added to staging and production environments
  • All related Jira tickets are linked in commit message(s)
  • Stakeholder approval has been confirmed (or is not needed)

Code Reviewer(s)

  • The commit message is clear and follows our guidelines (not just this PR message)
  • There are appropriate tests covering any new functionality
  • The provided documentation is sufficient for understanding any new functionality introduced
  • Any manual tests have been performed and verified
  • New dependencies are appropriate or there were no changes

ghukill added 2 commits June 3, 2025 14:40
@ghukill
Explicitly update TDA for make update
4b95848 
Why these changes are being introduced:

The TDA library is a Github dependency in the Pipefile, but the
normal `pipenv update --dev` does not pickup versions bumps in the
TDA library.  However, an explicit `pipenv update <TDA_URL>` will.

How this addresses that need:
* Adds an explicit TDA update in the `make update` command

Side effects of this change:
* TDA is updated to v2.0 (current)

Relevant ticket(s):
* https://mitlibraries.atlassian.net/browse/TIMX-496
@ghukill
Updates some tests to use stderr
3bfc23c
@ghukill ghukill requested a review from a team June 3, 2025 18:46
@ehanson8 ehanson8 self-assigned this Jun 3, 2025
@ghukill ghukill merged commit cdd42f8 into main Jun 3, 2025
3 checks passed
@coveralls
Copy link

Pull Request Test Coverage Report for Build 15425334985

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.783%
Totals Coverage Status
Change from base Build 14934229728: 0.0%
Covered Lines: 397
Relevant Lines: 406
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehanson8 ehanson8 ehanson8 approved these changes

Assignees

@ehanson8 ehanson8

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ghukill @coveralls @ehanson8