Update dependencies #117
Open
Update dependencies #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bougeant
approved these changes
Feb 15, 2024
|
Thank you for reviewing and approving these changes. I do not have write access to this repo, so I cannot perform the merge myself. |
|
I am also facing an issue with the dependencies, and this PR seems to solve them. I think it would solve #114 as well. |
|
Speaking up again to sa that I am facing this issue and merging this PR would be really helpful! I excited to be able to try this properly in my project. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to its very specific dependency requirements (exactly equal to specific subversions), this library is starting to become incompatible with other libraries in the ML space. I propose to follow the convention of only requiring a specific major version, and allowing the package manager freedom to decide on the minor version. I don't see specific reasons why OCTIS is not compatible with higher minor versions of gensim, scikit-learn and numpy.