Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature - Manage cryptographic material and secure file storage integration #24

Merged
merged 58 commits into from
Dec 19, 2024
Merged

Feature - Manage cryptographic material and secure file storage integration #24

merged 58 commits into from
Dec 19, 2024

Conversation

MGTheTrain
Copy link
Owner

@MGTheTrain MGTheTrain commented Dec 19, 2024 •
edited
Loading

Checklist

  • I adhere the trunk-based workflow
  • I verify that the CHANGELOG.md includes comprehensive documentation for the implemented features or fixed bugs. Increment the minor version such as from 0.1.0 to 0.2.0 for implemented features and increment the patch version from 0.1.0 to 0.1.1 for bug fixes. If any breaking changes occur, increment the major version, like from 0.1.0 to 1.0.0. Also see Semantic Versioning 2.0.0
  • I ensure that all merge conflicts are resolved before asking for a PR reviewer
  • To ensure the success of all pull request workflows, I run the format-and-lint.sh and run-test.sh locally.

Reference/Link to the issue solved with this PR (if any)

  • Manage cryptographic material: Enabled management of private/public key pairs and symmetric keys and implemented key lifecycle management including primarily key generation and key export
  • Secure file storage integration: Provided mechanisms to securely store encrypted files in Azure Blob Storage

@MGTheTrain
fix comments
c3733a4
@MGTheTrain
consider upload endpoints utilizing multipart form
19e4b8b
@MGTheTrain
adhere to DRY
7d6f01a
@MGTheTrain
add missing checks
5f56375
@MGTheTrain
adhere to DRY and test all connector endpoints
3d35d12
@MGTheTrain
modify Upload(...) signature and implementation
691eb10
@MGTheTrain
modify mocks
7374bca
@MGTheTrain
adjust integration test
fea19a5
@MGTheTrain
remove comment
ea7dded
@MGTheTrain
add New...(...) functions in key services and fix corresponding tests
7a4e8cf
@MGTheTrain
rename input argument
7e0591b
@MGTheTrain
update DDD ADR
9ed7844
@MGTheTrain
consider key size members attribute in CryptoKeyMeta struct; add cust…
459caff 
…om key size validation function
@MGTheTrain
consider key size in affected signatures
2d73e51
@MGTheTrain
modify vault connector and ked upload service signatures and implemen…
1a51239 
…tations
@MGTheTrain
forward error from underlying components
7ac3786
@MGTheTrain
replace obsolete interface signature
db965df
@MGTheTrain
update ADR document and EDR diagram-as-code
99c5647
@MGTheTrain
consider KeyPairId member attribute in CryptoKeyMeta struct
4dceec5
@MGTheTrain
remove code duplications and improve readability trough helper functions
baeb935
@MGTheTrain
forward only errors from underlying components
13e381e
@MGTheTrain
remove obsolete mock test
0120d61
@MGTheTrain
modify Download(...) signature and implementation of key download ser…
f49f081 
…vice
@MGTheTrain
modify bullet points
eaad2dc
@MGTheTrain
consider rollback in case upload fails
c6ea4d8
@MGTheTrain
rmove obsolete comments
1a5f8f6
@MGTheTrain
modify attributes in BlobMeta struct
057df61
@MGTheTrain
rename files and move logic
cea2110
@MGTheTrain
rename input argument
3979802
@MGTheTrain
remove unused signature and implementation
40d8b17
@MGTheTrain
modify descriptions in helper functions and update Download(...) sign…
25efb35 
…ature in blob services
@MGTheTrain
modify Download(...) signature and implementation
5dcbb51
@MGTheTrain
add initial integration test for blob services
2d05a20
@MGTheTrain
modify branching and blob services tests
40d2f06
@MGTheTrain
add helper function utilized in blob services tests
401acc3
@MGTheTrain
utilize helper function in blob connector tests
9a9fce2
@MGTheTrain
utilize variables
6dffa34
@MGTheTrain
remove comment
6c26964
@MGTheTrain
add List(...) methods in repository structs
714dbe7
@MGTheTrain
test all public repository methods
f0a3465
@MGTheTrain
utilize List(...) method
005bb03
@MGTheTrain
consider test case for successful blob upload with encryption and sig…
3179fe7 
…ning
@MGTheTrain
decode before parsing key bytes
d8b8d54
@MGTheTrain
change license due to use of opensc components
0abf27e
@MGTheTrain
utilize correct methods for parsing and modify Upload(...) signature …
f71125a 
…of blob connector
@MGTheTrain
fix log
3626622
@MGTheTrain
fix EC signing scope in applyCryptographicOperation(...)
bb371bd
@MGTheTrain
fix logs
8adc62a
@MGTheTrain
fix check
a38b4bc
@MGTheTrain
modify custom validator checks
0ef13e6
@MGTheTrain
map key size in bytes to key size in bits
5388c8f
@MGTheTrain
consider test case with EC signing and AES encryption
220450e
@MGTheTrain
modify bullet points and document changes
9e087c5
@MGTheTrain
striketrough
1276c91
@MGTheTrain
add comment
a5a9ac7
@MGTheTrain
fix linter findings
0d78640
@MGTheTrain
past tense
8620e55
@MGTheTrain MGTheTrain changed the title Feature/secure file storage Feature - Manage cryptographic material and secure file storage integration Dec 19, 2024
@MGTheTrain MGTheTrain merged commit 56044e7 into main Dec 19, 2024
2 checks passed
@MGTheTrain MGTheTrain deleted the feature/secure-file-storage branch December 19, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@MGTheTrain