Axisymmetric Hypoelasticity

[ChrisZYJ]

Description

Implements cylindrical axisymmetric hypoelasticity (cyl_coord).

Adds an additional hoop stress equation. Additional source and geometric source terms are also added.

Type of change

• New feature (non-breaking change which adds functionality)

Scope

• This PR comprises a set of related changes with a common goal

How Has This Been Tested?

• Comparing 2D Axisym with 3D (the small discrepancies are likely due to boundary conditions, present even without hypoelasticity enabled; see Fix Axisymmetric HLL #794)

AxisymHypoWorks.mp4

Checklist

• I have added comments for the new code
• I added Doxygen docstrings to the new code
• I have made corresponding changes to the documentation (docs/)
• I have added regression tests to the test suite so that people can verify in the future that the feature is behaving as expected
• I have added example cases in examples/ that demonstrate my new feature performing as expected.
  They run to completion and demonstrate "interesting physics"
• I ran ./mfc.sh format before committing my code
• New and existing tests pass locally with my changes, including with GPU capability enabled (both NVIDIA hardware with NVHPC compilers and AMD hardware with CRAY compilers) and disabled
• This PR does not introduce any repeated code (it follows the DRY principle)
• I cannot think of a way to condense this code and reduce any introduced additional line count

If your code changes any code source files (anything in src/simulation)

To make sure the code is performing as expected on GPU devices, I have:

• Checked that the code compiles using NVHPC compilers
• Checked that the code compiles using CRAY compilers
• Ran the code on either V100, A100, or H100 GPUs and ensured the new feature performed as expected (the GPU results match the CPU results)
• Ran the code on MI200+ GPUs and ensure the new features performed as expected (the GPU results match the CPU results)
• Enclosed the new feature via nvtx ranges so that they can be identified in profiles
• Ran a Nsight Systems profile using ./mfc.sh run XXXX --gpu -t simulation --nsys, and have attached the output file (.nsys-rep) and plain text results to this PR
• Ran an Omniperf profile using ./mfc.sh run XXXX --gpu -t simulation --omniperf, and have attached the output file and plain text results to this PR.
• Ran my code using various numbers of different GPUs (1, 2, and 8, for example) in parallel and made sure that the results scale similarly to what happens if you run without the new code/feature

[codecov]

Codecov Report

Attention: Patch coverage is 25.00000% with 24 lines in your changes missing coverage. Please review.

Project coverage is 43.61%. Comparing base (775d08d) to head (388c4f3).
Report is 1 commits behind head on master.

Files with missing lines	Patch %	Lines
src/simulation/m_hypoelastic.fpp	26.66%	10 Missing and 1 partial ⚠️
src/simulation/m_riemann_solvers.fpp	44.44%	4 Missing and 1 partial ⚠️
src/common/m_variables_conversion.fpp	0.00%	1 Missing and 2 partials ⚠️
src/simulation/m_checker.fpp	0.00%	2 Missing ⚠️
src/post_process/m_global_parameters.fpp	0.00%	0 Missing and 1 partial ⚠️
src/pre_process/m_global_parameters.fpp	0.00%	0 Missing and 1 partial ⚠️
src/simulation/m_global_parameters.fpp	0.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #815      +/-   ##
==========================================
+ Coverage   43.54%   43.61%   +0.06%     
==========================================
  Files          66       66              
  Lines       19725    19748      +23     
  Branches     2405     2413       +8     
==========================================
+ Hits         8590     8613      +23     
+ Misses       9660     9653       -7     
- Partials     1475     1482       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[sbryngelson]

@ChrisZYJ is this ready to merge after review?

[sbryngelson]

remove this line?

[ChrisZYJ]

@sbryngelson It's ready to merge