Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sphere smoothing #798

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

wilfonba
Copy link
Contributor

@wilfonba wilfonba commented Feb 5, 2025

Description

This PR fixes a bug in the smoothing function for spherical patches that was identified during IGR development. The smoothing was only being applied inside the nominal radius of the patch, resulting in a grid level discontinuity. The old code generates the following IC
old
Which shows smoothing only on the sphere's interior and a discontinuity on the outer surface. The new code generates the following IC
new
which shows smoothing on both sides of the nominal radius of the patch. The smoothing coefficient for both ICs is identical.

Fixes #(issue) [optional]

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Scope

  • This PR comprises a set of related changes with a common goal

@wilfonba wilfonba requested a review from a team as a code owner February 5, 2025 19:45
@wilfonba
Copy link
Contributor Author

wilfonba commented Feb 5, 2025

@haochey Says this is likely an issue for some other patches as well and he's going to resolve it in this PR.

Copy link

codecov bot commented Feb 5, 2025

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.

Project coverage is 43.74%. Comparing base (131b41e) to head (105f30a).

Files with missing lines Patch % Lines
src/pre_process/m_patches.fpp 0.00% 11 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #798   +/-   ##
=======================================
  Coverage   43.74%   43.74%           
=======================================
  Files          65       65           
  Lines       19039    19039           
  Branches     2332     2332           
=======================================
  Hits         8328     8328           
- Misses       9303     9305    +2     
+ Partials     1408     1406    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sbryngelson
Copy link
Member

@haochey let me know when this is ready

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants