Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Axisymmetric HLL #794

Merged
merged 3 commits into from
Jan 28, 2025
Merged

Fix Axisymmetric HLL #794

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b321389
fix HLL axisym
ChrisZYJ Jan 26, 2025
3384c8f
add test
ChrisZYJ Jan 26, 2025
bc483c2
formatting
ChrisZYJ Jan 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions src/simulation/m_riemann_solvers.fpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -858,6 +858,31 @@
flux_src_rs${XYZ}$_vf(j, k, l, i) = 0._wp
end do
end if

#:if (NORM_DIR == 2)
if (cyl_coord) then
!Substituting the advective flux into the inviscid geometrical source flux
!$acc loop seq
do i = 1, E_idx
flux_gsrc_rs${XYZ}$_vf(j, k, l, i) = flux_rs${XYZ}$_vf(j, k, l, i)

Check warning on line 867 in src/simulation/m_riemann_solvers.fpp

View check run for this annotation

Codecov / codecov/patch

src/simulation/m_riemann_solvers.fpp#L867 

Added line #L867 was not covered by tests
end do
! Recalculating the radial momentum geometric source flux
flux_gsrc_rs${XYZ}$_vf(j, k, l, contxe + dir_idx(1)) = &
(s_M*(rho_R*vel_R(dir_idx(1)) &

Check warning on line 871 in src/simulation/m_riemann_solvers.fpp

View check run for this annotation

Codecov / codecov/patch

src/simulation/m_riemann_solvers.fpp#L870-L871 

Added lines #L870 - L871 were not covered by tests
*vel_R(dir_idx(1))) &
- s_P*(rho_L*vel_L(dir_idx(1)) &
*vel_L(dir_idx(1))) &
+ s_M*s_P*(rho_L*vel_L(dir_idx(1)) &
- rho_R*vel_R(dir_idx(1)))) &
/(s_M - s_P)
! Geometrical source of the void fraction(s) is zero
!$acc loop seq
do i = advxb, advxe
flux_gsrc_rs${XYZ}$_vf(j, k, l, i) = 0._wp

Check warning on line 881 in src/simulation/m_riemann_solvers.fpp

View check run for this annotation

Codecov / codecov/patch

src/simulation/m_riemann_solvers.fpp#L881 

Added line #L881 was not covered by tests
end do
end if
#:endif

end do
end do
end do
Expand Down
176 changes: 176 additions & 0 deletions tests/6FE484B5/golden-metadata.txt
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

14 changes: 14 additions & 0 deletions tests/6FE484B5/golden.txt
View file
Open in desktop

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions toolchain/mfc/test/cases.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,6 +251,7 @@ def alter_2d():

cases.append(define_case_d(stack, "model_eqns=2", {'model_eqns': 2}))
cases.append(define_case_d(stack, "model_eqns=3", {'model_eqns': 3}))
cases.append(define_case_d(stack, "HLL", {'riemann_solver': 1}))

stack.push("Viscous", {
'fluid_pp(1)%Re(1)' : 0.0001, 'fluid_pp(1)%Re(2)' : 0.0001,
Expand Down
Loading