-
Notifications
You must be signed in to change notification settings - Fork 121
Volume filtered Euler-Lagrange framework for particle-laden flow explicit unclosed term computation #1043
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
2hrs for Frontier CI (MFlowCode#832)
| call s_mpi_allreduce_min(y_domain%beg, y_domain_beg) | ||
| call s_mpi_allreduce_max(y_domain%end, y_domain_end) | ||
| call s_mpi_allreduce_min(z_domain%beg, z_domain_beg) | ||
| call s_mpi_allreduce_max(z_domain%end, z_domain_end) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In moving IBs, the levelset is recomputed every RK substep, so this will get done usually 3x number of time steps, but we only need it done once. It also doesn't amek sense to only have the minimum and maximum beginning and end when calculaing sphere. You should move this somewhere else. Probably into the MPI proxy file
| ! Updating the patch identities bookkeeping variable | ||
| ib_markers_sf(i, j, k) = patch_id | ||
| end if | ||
| end if |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.

Description
Please include a summary of the changes and the related issue(s) if they exist.
Please also include relevant motivation and context.
Fixes #(issue) [optional]
-Overarching goal of investigating unclosed terms present in the volume filtered Euler-Lagrange framework
-Implements explicit computation of the unclosed terms present in the volume filtered momentum equation in the Euler-Lagrange framework for particle laden flows
-Explicit immersed boundary drag force computation
-General field statistics computation (1st-4th order statistical moments)
-Periodic spherical immersed boundaries
-Bulk flow periodic forcing
Type of change
Please delete options that are not relevant.
Scope
If you cannot check the above box, please split your PR into multiple PRs that each have a common goal.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Provide instructions so we can reproduce.
Please also list any relevant details for your test configuration
Test Configuration:
-MacOs
-Linux (Ubuntu)
-NCSA Delta Nvidia A100 GPUs
Checklist
docs/)examples/that demonstrate my new feature performing as expected.They run to completion and demonstrate "interesting physics"
./mfc.sh formatbefore committing my codeIf your code changes any code source files (anything in
src/simulation)To make sure the code is performing as expected on GPU devices, I have:
nvtxranges so that they can be identified in profiles./mfc.sh run XXXX --gpu -t simulation --nsys, and have attached the output file (.nsys-rep) and plain text results to this PR./mfc.sh run XXXX --gpu -t simulation --rsys --hip-trace, and have attached the output file and plain text results to this PR.