Skip to content

Commit

Permalink
Fixes for Xcode 16/Swift 6
Browse files Browse the repository at this point in the history
strict-concurrency-fix
  • Loading branch information
roanutil committed Jun 13, 2024
1 parent 10e763b commit 5d9085e
Show file tree
Hide file tree
Showing 3 changed files with 47 additions and 47 deletions.
25 changes: 11 additions & 14 deletions Package.swift
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,13 @@ let package = Package(
.library(name: "ArgumentEncoding", targets: ["ArgumentEncoding"]),
],
dependencies: [
.dependencies,
.dependencies(),
],
targets: [
.target(
name: "ArgumentEncoding",
dependencies: [
.dependencies,
.dependencies(),
],
swiftSettings: .swiftSix
),
Expand All @@ -32,25 +32,22 @@ let package = Package(
// MARK: PointFree

extension Package.Dependency {
static let dependencies: Package.Dependency = .package(
url: "https://github.com/pointfreeco/swift-dependencies.git",
.upToNextMajor(from: "1.0.0")
)
static func dependencies() -> Package.Dependency {
.package(
url: "https://github.com/pointfreeco/swift-dependencies.git",
.upToNextMajor(from: "1.0.0")
)
}
}

extension Target.Dependency {
static let dependencies: Self = .product(name: "Dependencies", package: "swift-dependencies")
static func dependencies() -> Self {
.product(name: "Dependencies", package: "swift-dependencies")
}
}

extension [SwiftSetting] {
static let swiftSix: Self = [
.enableUpcomingFeature("BareSlashRegexLiterals"),
.enableUpcomingFeature("ConciseMagicFile"),
.enableUpcomingFeature("DeprecateApplicationMain"),
.enableUpcomingFeature("DisableOutwardActorInference"),
.enableUpcomingFeature("ForwardTrailingClosures"),
.enableUpcomingFeature("ImportObjcForwardDeclarations"),
.enableUpcomingFeature("InternalImportsByDefault"),
.enableExperimentalFeature("StrictConcurrency"),
]
}
39 changes: 14 additions & 25 deletions [email protected]
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// swift-tools-version: 5.8
// swift-tools-version: 6.0

import PackageDescription

Expand All @@ -9,48 +9,37 @@ let package = Package(
.library(name: "ArgumentEncoding", targets: ["ArgumentEncoding"]),
],
dependencies: [
.dependencies,
.dependencies(),
],
targets: [
.target(
name: "ArgumentEncoding",
dependencies: [
.dependencies,
],
swiftSettings: .swiftSix
.dependencies(),
]
),
.testTarget(
name: "ArgumentEncodingTests",
dependencies: [
"ArgumentEncoding",
],
swiftSettings: .swiftSix
]
),
]
)

// MARK: PointFree

extension Package.Dependency {
static let dependencies: Package.Dependency = .package(
url: "https://github.com/pointfreeco/swift-dependencies.git",
.upToNextMajor(from: "1.0.0")
)
static func dependencies() -> Package.Dependency {
.package(
url: "https://github.com/pointfreeco/swift-dependencies.git",
.upToNextMajor(from: "1.0.0")
)
}
}

extension Target.Dependency {
static let dependencies: Self = .product(name: "Dependencies", package: "swift-dependencies")
}

extension [SwiftSetting] {
static let swiftSix: Self = [
.enableUpcomingFeature("BareSlashRegexLiterals"),
.enableUpcomingFeature("ConciseMagicFile"),
.enableUpcomingFeature("DeprecateApplicationMain"),
.enableUpcomingFeature("DisableOutwardActorInference"),
.enableUpcomingFeature("ForwardTrailingClosures"),
.enableUpcomingFeature("ImportObjcForwardDeclarations"),
.enableUpcomingFeature("InternalImportsByDefault"),
.enableUpcomingFeature("StrictConcurrency"),
]
static func dependencies() -> Self {
.product(name: "Dependencies", package: "swift-dependencies")
}
}
30 changes: 22 additions & 8 deletions Tests/ArgumentEncodingTests/ArgumentGroupTests.swift
Original file line number Diff line number Diff line change
Expand Up @@ -250,14 +250,28 @@ final class ArgumentGroupTests: XCTestCase {
}
}

extension Array: ArgumentGroup, FormatterNode {
public var flagFormatter: ArgumentEncoding.FlagFormatter { FlagFormatter(prefix: .doubleDash) }
#if swift(>=6)
extension Array: @retroactive ArgumentGroup, @retroactive FormatterNode {
public var flagFormatter: ArgumentEncoding.FlagFormatter { FlagFormatter(prefix: .doubleDash) }

public var optionFormatter: ArgumentEncoding.OptionFormatter { OptionFormatter(prefix: .doubleDash) }
}
public var optionFormatter: ArgumentEncoding.OptionFormatter { OptionFormatter(prefix: .doubleDash) }
}

extension Dictionary: ArgumentGroup, FormatterNode {
public var flagFormatter: ArgumentEncoding.FlagFormatter { FlagFormatter(prefix: .doubleDash) }
extension Dictionary: @retroactive ArgumentGroup, @retroactive FormatterNode {
public var flagFormatter: ArgumentEncoding.FlagFormatter { FlagFormatter(prefix: .doubleDash) }

public var optionFormatter: ArgumentEncoding.OptionFormatter { OptionFormatter(prefix: .doubleDash) }
}
public var optionFormatter: ArgumentEncoding.OptionFormatter { OptionFormatter(prefix: .doubleDash) }
}
#else
extension Array: ArgumentGroup, FormatterNode {
public var flagFormatter: ArgumentEncoding.FlagFormatter { FlagFormatter(prefix: .doubleDash) }

public var optionFormatter: ArgumentEncoding.OptionFormatter { OptionFormatter(prefix: .doubleDash) }
}

extension Dictionary: ArgumentGroup, FormatterNode {
public var flagFormatter: ArgumentEncoding.FlagFormatter { FlagFormatter(prefix: .doubleDash) }

public var optionFormatter: ArgumentEncoding.OptionFormatter { OptionFormatter(prefix: .doubleDash) }
}
#endif

0 comments on commit 5d9085e

Please sign in to comment.