Skip to content

Correct/Update CI #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 21, 2023
Merged

Correct/Update CI #106

merged 4 commits into from
Feb 21, 2023

Conversation

joaomcteixeira
Copy link
Member

@joaomcteixeira joaomcteixeira commented Feb 20, 2023

Closes #105, #107

The problem is that long_description in setup.cfg can only accept two files. Or at least setting two is does not work the same as for toml syntax.

To see if it works:

tox -e build

Go to dist/ open the .whl file and see the METADATA file. The README description for PyPI is there.

@joaomcteixeira joaomcteixeira self-assigned this Feb 20, 2023
@joaomcteixeira joaomcteixeira added the bug Something isn't working label Feb 20, 2023
@orbeckst
Copy link
Member

You can also create the test package on test.PyPi.org — we do this for most of our packages. This will allow you to check everything.

@PicoCentauri PicoCentauri force-pushed the i105 branch 2 times, most recently from 97918ce to ec5b1fb Compare February 21, 2023 10:19
* remove py3.8
* try fixing codecov
* move setup.py into pyproject.toml
@codecov
Copy link

codecov bot commented Feb 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.06%. Comparing base (99e89dd) to head (eb7f53f).
Report is 21 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #106      +/-   ##
==========================================
- Coverage   83.42%   83.06%   -0.37%     
==========================================
  Files           8        8              
  Lines         555      555              
  Branches      116      116              
==========================================
- Hits          463      461       -2     
- Misses         75       77       +2     
  Partials       17       17              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joaomcteixeira joaomcteixeira changed the title Correct readme in pypi Correct/Update CI Feb 21, 2023
@joaomcteixeira
Copy link
Member Author

@PicoCentauri , I see you want to move to pyproject.toml. So we should update tox accordingly and others. Do you agree? Just this week I got a PR and have been working on it joaomcteixeira/python-project-skeleton#33

@PicoCentauri
Copy link
Collaborator

Thanks for the link. I will update our files accordingly.

Copy link
Collaborator

@PicoCentauri PicoCentauri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am happy with the new structure. If you @joaomcteixeira also agree we can merge this.

@PicoCentauri PicoCentauri merged commit ec7ba2a into main Feb 21, 2023
@PicoCentauri PicoCentauri deleted the i105 branch February 21, 2023 21:17
@PicoCentauri PicoCentauri mentioned this pull request Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PyPI Readme
3 participants