Memory based autosplitter #219
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whoops. This fixes the autosplitter only auto-starting once and then you gotta restart the game
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created the previous autosplitter when I was less comfortable with writing livesplit autosplitters, and opted for a file-based approach. This isn't recommended since the OS and device IO have time to get in the way and make timings inaccurate.
This pull request updates the autosplitter class to allocate a chunk of memory with an easily scannable header and known layout. An external memory scanner can find the header and drive the timer start/split/load removal functionality. I have implemented that auto splitter here for use in the LiveSplit Auto Splitting Runtime: https://codeberg.org/thearst3rd/openmbu-asr