Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 6 #2504

Merged
merged 343 commits into from
Oct 26, 2024
Merged

Version 6 #2504

merged 343 commits into from
Oct 26, 2024

Conversation

ildyria
Copy link
Member

@ildyria ildyria commented Jul 20, 2024

Fixes #106
Closes #126
Fixes #226 (SE)
Closes #520 (SE)
Fixes #987
Fixes #1420
Closes #1641 (SE)
Fixes #1987
Fixes #2082
Fixes #2086
Fixes #2168
Fixes #2194
Fixes #2361
Fixes #2495

@tinohager
Copy link
Contributor

Is there already a time horizon for completion :) ?

@ildyria
Copy link
Member Author

ildyria commented Aug 2, 2024

I wish. :')

I have a PR here to create a small blog:
LycheeOrg/LycheeOrg.github.io#132

waiting for reviews. :)
The blog aims to provide some highlight of the work in progress on V6.

@tinohager
Copy link
Contributor

The site looks nice. The main menu item "Docs" has no content yet. If I understand correctly, this project will also replace the current project website?

@ildyria
Copy link
Member Author

ildyria commented Aug 4, 2024

No, just an update/refresher of the LycheeOrg website, nothing much there.
The make command build the full thing in dist (including the docs ;) ).

@tinohager

This comment was marked as off-topic.

@ildyria

This comment was marked as outdated.

@ildyria

This comment was marked as outdated.

@opravil-jan

This comment was marked as off-topic.

@ildyria

This comment was marked as off-topic.

@tinohager

This comment was marked as resolved.

@tinohager

This comment was marked as resolved.

@tinohager

This comment was marked as resolved.

@tinohager

This comment was marked as resolved.

@ildyria
Copy link
Member Author

ildyria commented Oct 9, 2024

Yeah I need to redo a lot of the translations. :(

@tinohager

This comment was marked as resolved.

@ildyria

This comment was marked as resolved.

@tinohager
Copy link
Contributor

"Upload track"
image

what should the button say at first glance I do not recognize what exactly the meaning of this button is

@tinohager

This comment was marked as resolved.

@ildyria
Copy link
Member Author

ildyria commented Oct 9, 2024

"Upload track" image

what should the button say at first glance I do not recognize what exactly the meaning of this button is

If you have gps data, you can upload a track xml data and that one will be displayed on the map in addition to the pictures.

@tinohager
Copy link
Contributor

"Upload track" image
what should the button say at first glance I do not recognize what exactly the meaning of this button is

If you have gps data, you can upload a track xml data and that one will be displayed on the map in addition to the pictures.

this is probably not a likely function for a standard user. I would direct this to a separate dialog where it is better described.

@tinohager

This comment was marked as resolved.

@tinohager

This comment was marked as resolved.

@tinohager

This comment was marked as resolved.

@tinohager

This comment was marked as resolved.

@ildyria

This comment was marked as resolved.

@ildyria

This comment was marked as resolved.

@tinohager

This comment was marked as resolved.

@tinohager

This comment was marked as resolved.

@tinohager
Copy link
Contributor

Apply composer update on lychee update via web interface

Probably not available in the Docker version either

@tinohager
Copy link
Contributor

Language used by Lychee

I would move it to the Config section for Owner and Title

@tinohager
Copy link
Contributor

Hide current version number

use Lychee instead of current

Hide Lychee version number

@tinohager
Copy link
Contributor

Force 32 bit legacy identifiers in the database

What can the setting?

@tinohager
Copy link
Contributor

Frequency of Lychee update checks

There is a number which unit has this?

Automatically check for new updates

The 2 points would probably belong together

@tinohager
Copy link
Contributor

There are some settings in the video area that could be merged.

  • Defines whether ffmpeg processing is available
  • Use local takestamp for the following video formats
  • Path to the binary of ffmpeg (not needed for docker)
  • Path to the binary of ffprobe (not needed for docker)

@tinohager
Copy link
Contributor

Mod NSFW

Does not speak for itself the title Sensitive Albums would perhaps bring more clarity

@tinohager

This comment was marked as resolved.

@tinohager
Copy link
Contributor

Zip compression level.

Does this make any sense at all as the images are already compressed as jpeg. The size will probably not really improve significantly

Use Zip 64bits instead of 32 bits

Probably not usable in Docker either

@tinohager

This comment was marked as resolved.

@tinohager
Copy link
Contributor

image

However, the message does not disappear

Missing medium
Found 1 medium that could be generated.

@tinohager

This comment was marked as resolved.

@tinohager

This comment was marked as resolved.

@tinohager
Copy link
Contributor

We don't really have a big Benfit here

image

@ildyria
Copy link
Member Author

ildyria commented Oct 24, 2024

Quite a few things to improve...
I think for the settings, I will need to refactor quite a bit the way the sections are currently divided.

On one hand, I can see why this is a bit overwhelming, but on the other hand I would like this to be transparent for users, so that they don't feel that they have to look through each tab one by one... (that is why I added the menu on the right to jump directly to a section or another. That way users can just scroll down to discover the settings, one page, nothing hidden, but also have quick access to each part.

One thing that I am missing as capabilities in this page, is the ability to reorder (as a dev) the settings and the categories.
That is something I will most likely rework.

I also do agree that footer can probably be split, moved in some other section.

What I am unsure is whether this refactoring should happen before or after release of v6. I do not want to put too much pressure on my dear @d7415 :)

@tinohager
Copy link
Contributor

tinohager commented Oct 24, 2024

The Setting Page optimization can of course also come with 6.1.

I think this is primarily about a sensibly organized settings dialogue. Probably a small pull request from my point of view. If you don't want a tab then we could pursue an approach with the right menu. And integrate the important points at the beginning and then list the detailed settings further down.

Copy link
Contributor

@d7415 d7415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm clicking approve because at this point I can't remember many of the comments, but I don't think any were critical. Most are about comments.

app/Enum/DateOrderingType.php Outdated Show resolved Hide resolved
app/Policies/AlbumPolicy.php Outdated Show resolved Hide resolved
app/Policies/SettingsPolicy.php Show resolved Hide resolved
app/SmartAlbums/BaseSmartAlbum.php Outdated Show resolved Hide resolved
database/migrations/2024_07_29_172018_fix_settings.php Outdated Show resolved Hide resolved
resources/js/views/gallery-panels/Map.vue Outdated Show resolved Hide resolved
resources/js/views/gallery-panels/Map.vue Outdated Show resolved Hide resolved
resources/js/views/gallery-panels/Photo.vue Outdated Show resolved Hide resolved
resources/js/views/gallery-panels/Photo.vue Show resolved Hide resolved
resources/js/composables/selections/selections.ts Outdated Show resolved Hide resolved
@tinohager
Copy link
Contributor

Then we are now ready to start the merge here? 🤩

@tinohager
Copy link
Contributor

Proposal

Lychee

We are excited to announce the release of Lychee version 6! This new version brings a major upgrade with a completely reworked frontend built on Vue.js. By leveraging the power and flexibility of Vue, we've enhanced the overall user experience, making the interface more responsive, modern, and easier to navigate.

@ildyria
Copy link
Member Author

ildyria commented Oct 25, 2024

Then we are now ready to start the merge here? 🤩

Someone made quite a few comments on this PR, so that someone will have to wait for that stack of 17 PR to be collapse into this one. 🤣 Then we will be able to merge. 😄

So once @d7415 reviewed 8, 9, 10, 11, 13, 14, 15, 16, 17, I will apply the merges and then Version 6 will be live.

Proposal

Lychee

We are excited to announce the release of Lychee version 6! This new version brings a major upgrade with a completely reworked frontend built on Vue.js. By leveraging the power and flexibility of Vue, we've enhanced the overall user experience, making the interface more responsive, modern, and easier to navigate.

I actually quite like the image, the text feels still a bit too ChatGPT~ish :)
I will need to create a blog post here for it.
I already started working on a draft of the release note: LycheeOrg/LycheeOrg.github.io#159

@d7415
Copy link
Contributor

d7415 commented Oct 25, 2024

That is a weird image. But I am on board with an anthropomorphised lychee.

* Stacked 2: Fix sharing - add icon to indicate read access (#2564)
* Stacked 3: fix play icon not showing on images (#2579)
* Stacked 4: Fix error message : details on upload (#2566)
* Stacked 5: Fix visibility updated wrong message (#2567)
* Stacked 6: Fix styling of left menu per @d7415 request :D (#2568)
* Stacked 7: Clear create album name on creation/move (#2569)
* Stacked 8: Fix visibility not updating when traversing albums (#2570)
* Stacked 9: Remove redundant auth check query (#2572)
* Stacked 10: Add footer also in albums and album (#2571)
* Stacked 11: Fix VueJs not usable in sub folders. (#2573)
* Staked 12: Fix qr code not working (#2576)
* Stacked 13: Statistics per album (#2577)
* Stacked 14: Allow to chose the photo layout per album (#2575)
* Stacked 15: Show owner instead of just Shared albums (#2574)
* Stacked 16: Composer update + fixing phpstan / Ts checker (#2580)
* Stacked 17: Various fixes. (#2581)

---------

Co-authored-by: Martin Stone <[email protected]>
@ildyria ildyria changed the title WIP v6 Version 6 Oct 26, 2024
@ildyria ildyria merged commit b156ec4 into master Oct 26, 2024
47 checks passed
@ildyria ildyria deleted the v6 branch October 26, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment