Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inverted date on album tiles with multiple months #2495

Closed
2 tasks done
jsaathof opened this issue Jul 5, 2024 Discussed in #2433 · 3 comments · Fixed by #2504
Closed
2 tasks done

Inverted date on album tiles with multiple months #2495

jsaathof opened this issue Jul 5, 2024 Discussed in #2433 · 3 comments · Fixed by #2504
Labels
Low Priority Low priority issues

Comments

@jsaathof
Copy link
Contributor

jsaathof commented Jul 5, 2024

@ildyria Sorry to bother you again with this issue but the change you made actually made it worse. Now the date inside the album is inverted as well. I wanted the date on the album tile to be fixed.

Now both the album tile and the date inside the album both read "May - Apr" instead of "Apr - May" which is more logical to me. I do give you credit that is consistent at the moment but I would have liked the fix on the album tile, not the inside the album.

BtW this is also the case in the new 5.5.0 version.

Thanks in advance.

Jurriaan

Discussed in #2433

Originally posted by jsaathof May 13, 2024

Lychee version

v5.3.0

Which PHP version are you using?

PHP 8.2

Detailed description of the problem

Hi,

I have noticed a cosmetic bug in the display of the date for the album. I have sorted the albums in descending order of "Latest take date". The photos in the album are sorted ascending. The date on the album is printed inverted. When I enter the album the dates are correctly reported.

I would expect the date to be - (as a human) or be set to the ordering inside the album (although as a human this does not compute to me ;-) ) At least the dates are printed not consistently.

Album:
Screenshot 2024-05-13 at 12 01 11

Inside the album:
Screenshot 2024-05-13 at 12 02 14

I can't remember when this worked correctly but I know it did. Maybe this changed with the new front-end.

I am using the docker image.

Steps to reproduce the issue

  1. create an album
  2. add photos over multiple months
  3. see the dates

Diagnostics [REQUIRED]

    Diagnostics
    -----------
        Warning: Dropbox import not working. dropbox_key is empty.
        Error: APP_URL (https://photo**********ia.nl) does not match the current url (http://photo**********ia.nl).
               This will break WebAuthn authentication.
        Error: APP_URL (https://photo**********ia.nl) does not match the current url (http://photo**********ia.nl).
               This will prevent images from being properly displayed.
        Info: Latest version of PHP is 8.3
        Warning: Online updates are disabled by configuration
    

    System Information
    ------------------
        Lychee Version (tag):                    v5.3.0 (e8f442e) -- Up to date (4 hours ago).
        DB Version:                              5.3.0
        
        composer install:                        --no-dev
        APP_ENV:                                 production
        APP_DEBUG:                               false
        APP_URL:                                 set
        APP_DIR:                                 default
        LOG_VIEWER_ENABLED:                      true
        LIVEWIRE_ENABLED:                        true
        
        System:                                  Linux
        PHP Version:                             8.2.18
        PHP User agent:                          Lychee/4 (https://lycheeorg.github.io/)
        Timezone:                                Europe/Amsterdam
        Max uploaded file size:                  100M
        Max post size:                           100M
        Livewire chunk size:                     12.00 MB
        Max execution time:                      3600
        PostgreSQL Version:                      PostgreSQL 15.6 on x86_64-suse-linux-gnu, compiled by gcc (SUSE Linux) 7.5.0, 64-bit
        
        exec() Available:                        yes
        Imagick Available:                       1
        Imagick Enabled:                         1
        Imagick Version:                         1691
        GD Version:                              2.3.3
        Number of foreign key:                   12 found.
    

    Config Information
    ------------------
        version:                                 050300
        check_for_updates:                       0
        sorting_photos_col:                      title
        sorting_photos_order:                    ASC
        sorting_albums_col:                      max_taken_at
        sorting_albums_order:                    DESC
        imagick:                                 1
        skip_duplicates:                         0
        small_max_width:                         0
        small_max_height:                        360
        medium_max_width:                        1920
        medium_max_height:                       1080
        lang:                                    en
        image_overlay_type:                      none
        default_license:                         CC-BY-NC-ND-4.0
        compression_quality:                     90
        grants_full_photo_access:                1
        delete_imported:                         1
        mod_frame_enabled:                       0
        mod_frame_refresh:                       30
        landing_page_enable:                     0
        thumb_2x:                                1
        small_2x:                                0
        medium_2x:                               0
        force_migration_in_production:           0
        search_public:                           0
        hide_version_number:                     1
        recent_age:                              1
        SL_enable:                               0
        SL_for_admin:                            0
        grants_download:                         0
        photos_wraparound:                       1
        map_display:                             1
        zip64:                                   1
        map_display_public:                      1
        map_provider:                            RRZE
        force_32bit_ids:                         0
        map_include_subalbums:                   0
        update_check_every_days:                 3
        has_exiftool:                            1
        share_button_visible:                    0
        has_ffmpeg:                              0
        import_via_symlink:                      0
        location_decoding:                       1
        location_decoding_timeout:               30
        location_show:                           1
        location_show_public:                    0
        rss_enable:                              0
        rss_recent_days:                         7
        rss_max_items:                           100
        prefer_available_xmp_metadata:           0
        editor_enabled:                          1
        lossless_optimization:                   0
        swipe_tolerance_x:                       150
        swipe_tolerance_y:                       250
        local_takestamp_video_formats:           .avi|.mov
        log_max_num_line:                        1000
        unlock_password_photos_with_url_param:   0
        nsfw_visible:                            1
        nsfw_blur:                               0
        nsfw_warning:                            0
        nsfw_warning_admin:                      0
        nsfw_banner_override:                    
        map_display_direction:                   1
        album_subtitle_type:                     oldstyle
        upload_processing_limit:                 4
        new_photos_notification:                 0
        legacy_id_redirection:                   1
        zip_deflate_level:                       6
        SA_enabled:                              1
        default_album_protection:                1
        allow_username_change:                   1
        album_decoration:                        layers
        album_decoration_orientation:            row
        auto_fix_orientation:                    1
        use_job_queues:                          0
        random_album_id:                         starred
        use_last_modified_date_when_no_exif_date: 0
        layout:                                  square
        date_format_photo_thumb:                 M j, Y, g:i:s A e
        date_format_photo_overlay:               M j, Y, g:i:s A e
        date_format_sidebar_uploaded:            M j, Y, g:i:s A e
        date_format_sidebar_taken_at:            M j, Y, g:i:s A e
        date_format_hero_min_max:                F Y
        date_format_hero_created_at:             M j, Y, g:i:s A T
        date_format_album_thumb:                 M Y
        upload_chunk_size:                       0
        nsfw_banner_blur_backdrop:               0
        search_pagination_limit:                 1000
        search_minimum_length_required:          4
        photo_layout_justified_row_height:       320
        photo_layout_masonry_column_width:       300
        photo_layout_grid_column_width:          250
        photo_layout_square_column_width:        200
        photo_layout_gap:                        12
        display_thumb_album_overlay:             always
        display_thumb_photo_overlay:             hover
        default_album_thumb_aspect_ratio:        1/1
        use_album_compact_header:                0
        login_button_position:                   left
        back_button_enabled:                     0
        back_button_text:                        Return to Home
        current_job_processing_visible:          1

Browser & System [REQUIRED]

Firefox 125.0.2 on macOS Sonoma 14.4.1 (arm64)
Safari on IOS 17 (iPhone)

Please confirm (incomplete submissions will not be addressed)

  • I have provided easy and step-by-step instructions to reproduce the bug.
  • I understand my bug report will be removed if I haven't met the criteria above.
@ildyria
Copy link
Member

ildyria commented Jul 6, 2024

Hi,

I am sorry but I will have to put that one on the waiting to fix pile.
I am trying to no longer touch to the current front-end and am dedicating my time to the new one: see #2485.

What I will do in the new one is make this a configuration parameter: oldest-newest or newest-oldest date format.
However I will have to trouble you to wait until this is done.

I hope you understand. :(

@ildyria ildyria added the Low Priority Low priority issues label Jul 6, 2024
@jsaathof
Copy link
Contributor Author

jsaathof commented Jul 6, 2024

No problem. I have been very happy with Lychee. This is just a cosmetic issue.

@ildyria
Copy link
Member

ildyria commented Jul 6, 2024

Well... good news for you, I just implemented it on v6.
Bad news for you, I am far from being finished. 😆

Posting updates screenshots in the discord.

@LycheeOrg LycheeOrg deleted a comment from lonelyloulou Sep 13, 2024
@ildyria ildyria mentioned this issue Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Low Priority Low priority issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants