Skip to content

Commit 76d5a7a

Browse files
LuzkanGitVersioniser
authored andcommitted
[1.0.20] ✏️ Added missing source to MF1999 for Global Data (#13) #patch
1 parent 1eeb1ee commit 76d5a7a

File tree

3 files changed

+14
-5
lines changed

3 files changed

+14
-5
lines changed

content/smells/global-data.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ history:
7575

7676
## Global Data
7777

78-
The _Global Data_ is quite similar to the [Middle Man](./middle-man.md) code smell, but here rather than a class, the broker is the _global scope_ in which the data is freely available to everyone. These global scope variables are undesirable because it directly causes the [Hidden Dependencies](./hidden-dependencies.md) code smell and a highly nasty [Mutable Data](./mutable-data.md) code smell. Global data can be read from anywhere, and there is no easy way to discover which bit of code touches it. If the variable in the global scope is additionally mutable, then this becomes an extremally bad case of _[Mutable](./mutable-data.md) [Fate over Action](./fate-over-action.md) (data class)_. Fowler, in 1999 recalled that in the early days of programming, back when there were no objects, even causing the [Long Parameter List](./long-paramter-list.md) code smell was preferable to the Global Data [[35](#sources)]. For the same reasons, a Singleton Pattern can also be problematic [[17](#sources)].
78+
The _Global Data_ is quite similar to the [Middle Man](./middle-man.md) code smell, but here rather than a class, the broker is the _global scope_ in which the data is freely available to everyone. These global scope variables are undesirable because it directly causes the [Hidden Dependencies](./hidden-dependencies.md) code smell and a highly nasty [Mutable Data](./mutable-data.md) code smell. Global data can be read from anywhere, and there is no easy way to discover which bit of code touches it. If the variable in the global scope is additionally mutable, then this becomes an extremally bad case of _[Mutable](./mutable-data.md) [Fate over Action](./fate-over-action.md) (data class)_. Fowler, in 1999 recalled that in the early days of programming, back when there were no objects, even causing the [Long Parameter List](./long-paramter-list.md) code smell was preferable to the Global Data [[1](#sources)]. For the same reasons, a Singleton Pattern can also be problematic [[2](#sources)].
7979

8080
### Problems
8181

@@ -103,5 +103,5 @@ In the context of the system as a whole, some communication between modules must
103103

104104
##### Sources
105105

106-
- [[17](#sources)] - Martin Fowler, "Refactoring: Improving the Design of Existing Code (3rd Edition)" (2018)
107-
- [[35](#sources)] -
106+
- [[1](#sources)] - Martin Fowler, "Refactoring: Improving the Design of Existing Code" (1999)
107+
- [[2](#sources)] - Martin Fowler, "Refactoring: Improving the Design of Existing Code (3rd Edition)" (2018)

docs/CHANGELOG.md

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,11 +6,19 @@ All notable changes to this project will be documented in this file.
66

77
---
88

9+
## [[`1.0.20`]] - 2022-09-02
10+
11+
### Typo
12+
13+
- Added missing source to MF1999 for Global Data (#13) #patch
14+
15+
16+
917
## [[`1.0.19`]] - 2022-09-02
1018

1119
### Typo
1220

13-
- Retrieving Type Signature instead of Objects in Fallacious Method Name
21+
- Retrieving Type Signature instead of Objects in Fallacious Method Name
1422

1523
### Documentation
1624

@@ -252,3 +260,4 @@ All notable changes to this project will be documented in this file.
252260
[`1.0.17`]: https://github.com/Luzkan/smells/releases/tag/1.0.17
253261
[`1.0.18`]: https://github.com/Luzkan/smells/releases/tag/1.0.18
254262
[`1.0.19`]: https://github.com/Luzkan/smells/releases/tag/1.0.19
263+
[`1.0.20`]: https://github.com/Luzkan/smells/releases/tag/1.0.20

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "smells",
33
"description": "Code Smells Catalog",
4-
"version": "1.0.19",
4+
"version": "1.0.20",
55
"author": "Marcel Jerzyk",
66
"dependencies": {
77
"@emotion/react": "^11.8.2",

0 commit comments

Comments
 (0)