Skip to content

Commit 1eeb1ee

Browse files
rruiter87GitVersioniser
authored andcommitted
[1.0.19] ✏️📝 GetFoos Example Update in Fallacious Method Name #patch (#8)
✏️ Retrieving Type Signature instead of Objects in Fallacious Method Name 📝 Updated Example of retrieving Foos in Fallacious Method NameTypo: Retrieving Type Signature instead of Objects in Fallacious Method Name
1 parent d96e936 commit 1eeb1ee

File tree

3 files changed

+17
-3
lines changed

3 files changed

+17
-3
lines changed

content/smells/fallacious-method-name.md

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,8 @@ If someone would like to use a method with a given name, he should also expect t
135135
```py
136136
def getFoos() -> Foo:
137137
...
138-
return Foo
138+
foo: Foo = ...
139+
return foo
139140

140141
def isGoo() -> str:
141142
...
@@ -152,7 +153,7 @@ def setValue(self, value) -> Any:
152153
def getFoos() -> list[Foo]:
153154
...
154155
foos: list[Foo] = ...
155-
return list[Foo]
156+
return foos
156157

157158
def isGoo() -> bool:
158159
...

docs/CHANGELOG.md

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,18 @@ All notable changes to this project will be documented in this file.
66

77
---
88

9+
## [[`1.0.19`]] - 2022-09-02
10+
11+
### Typo
12+
13+
- Retrieving Type Signature instead of Objects in Fallacious Method Name
14+
15+
### Documentation
16+
17+
- Updated Example of retrieving Foos in Fallacious Method Name
18+
19+
20+
921
## [[`1.0.18`]] - 2022-09-02
1022

1123
### Typo
@@ -239,3 +251,4 @@ All notable changes to this project will be documented in this file.
239251
[`1.0.16-alpha.1`]: https://github.com/Luzkan/smells/releases/tag/1.0.16-alpha.1
240252
[`1.0.17`]: https://github.com/Luzkan/smells/releases/tag/1.0.17
241253
[`1.0.18`]: https://github.com/Luzkan/smells/releases/tag/1.0.18
254+
[`1.0.19`]: https://github.com/Luzkan/smells/releases/tag/1.0.19

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "smells",
33
"description": "Code Smells Catalog",
4-
"version": "1.0.18",
4+
"version": "1.0.19",
55
"author": "Marcel Jerzyk",
66
"dependencies": {
77
"@emotion/react": "^11.8.2",

0 commit comments

Comments
 (0)