Skip to content

Commit 145a554

Browse files
LuzkanGitVersioniser
authored andcommitted
[1.0.21] ✏️🛠️ Loops Href and Typo Fix in Example in Clever Code (#14)
✏️ Added missing double underscore in `__getitem__` in Clever Code 🛠️ Links to "Imperative Loops" article were adjusted Fix: Links to "Imperative Loops" article were adjusted #patch
1 parent 76d5a7a commit 145a554

File tree

7 files changed

+21
-12
lines changed

7 files changed

+21
-12
lines changed

content/smells/clever-code.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -117,15 +117,15 @@ def get_length_of_string(message: str) -> int:
117117

118118
message = 'Hello World!'
119119
message_length = get_length_of_string(message)
120-
print(message_length) # 12
120+
print(message_length) # 12
121121
```
122122

123123
#### Solution
124124

125125
```py
126126
message = 'Hello World!'
127127
message_length = len(message)
128-
print(message_length) # 12
128+
print(message_length) # 12
129129
```
130130

131131
</div>
@@ -144,7 +144,7 @@ class DefaultDict(dict):
144144
self.__setitem__(key, self.default_value())
145145
return super().__getitem__(key)
146146

147-
def __setitem(self, key, value):
147+
def __setitem__(self, key, value):
148148
super().__setitem__(key, value)
149149
```
150150

content/smells/conditional-complexity.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ relations:
3636
type:
3737
- caused
3838
- name: Loops
39-
slug: loops
39+
slug: imperative-loops
4040
type:
4141
- caused
4242
- name: Null Check

content/smells/flag-argument.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ relations:
3535
type:
3636
- causes
3737
- name: Loops
38-
slug: loops
38+
slug: imperative-loops
3939
type:
4040
- caused
4141
- name: Null Check

content/smells/obscured-intent.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ relations:
3535
type:
3636
- caused
3737
- name: Loops
38-
slug: loops
38+
slug: imperative-loops
3939
type:
4040
- caused
4141
- name: Complicated Boolean Expression

content/smells/status-variable.md

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -26,10 +26,6 @@ relations:
2626
slug: clever-code
2727
type:
2828
- co-exist
29-
- name: Loops
30-
slug: loops
31-
type:
32-
- co-exist
3329
- name: Afraid to Fail
3430
slug: afraid-to-fail
3531
type:
@@ -43,7 +39,7 @@ relations:
4339
type:
4440
- co-exist
4541
- name: Loops
46-
slug: loops
42+
slug: imperative-loops
4743
type:
4844
- caused
4945
problems:

docs/CHANGELOG.md

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,18 @@ All notable changes to this project will be documented in this file.
66

77
---
88

9+
## [[`1.0.21`]] - 2022-09-02
10+
11+
### Typo
12+
13+
- Added missing double underscore in `__getitem__` in Clever Code
14+
15+
### Fixed
16+
17+
- Links to "Imperative Loops" article were adjusted
18+
19+
20+
921
## [[`1.0.20`]] - 2022-09-02
1022

1123
### Typo
@@ -261,3 +273,4 @@ All notable changes to this project will be documented in this file.
261273
[`1.0.18`]: https://github.com/Luzkan/smells/releases/tag/1.0.18
262274
[`1.0.19`]: https://github.com/Luzkan/smells/releases/tag/1.0.19
263275
[`1.0.20`]: https://github.com/Luzkan/smells/releases/tag/1.0.20
276+
[`1.0.21`]: https://github.com/Luzkan/smells/releases/tag/1.0.21

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "smells",
33
"description": "Code Smells Catalog",
4-
"version": "1.0.20",
4+
"version": "1.0.21",
55
"author": "Marcel Jerzyk",
66
"dependencies": {
77
"@emotion/react": "^11.8.2",

0 commit comments

Comments
 (0)