Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps/opencolorio: fix missing cstring header #614

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

illwieckz
Copy link
Contributor

This fixes this build error:

LuxCore/deps/opencolorio-2.0.0/src/OpenColorIO/FileRules.cpp: In function ‘std::string OpenColorIO_v2_0::{anonymous}::ConvertToRegularExpression(const char*, bool)’:
LuxCore/deps/opencolorio-2.0.0/src/OpenColorIO/FileRules.cpp:63:31: error: ‘strlen’ was not declared in this scope
   63 |         const size_t length = strlen(globPattern);
      |                               ^~~~~~
LuxCore/deps/opencolorio-2.0.0/src/OpenColorIO/FileRules.cpp:17:1: note: ‘strlen’ is defined in header ‘<cstring>’; did you forget to ‘#include <cstring>’?

Like #596 one may want to look for an upstream fix if exists, but this patch fixes the bug with less effort until someone looks at updating deps.

This work is courtesy of I ♥ Compute initiative funded by 🇫🇷️ rebatir.fr.

@luzpaz
Copy link
Contributor

luzpaz commented Aug 3, 2023

any traction on this ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants