Limit reply keyboard options

Resolves #219

bot/replyKeyboards.go

@@ -1,6 +1,7 @@
 package bot
 
 import (
+	"github.com/LucaBernstein/beancount-bot-tg/helpers"
 	tb "gopkg.in/telebot.v3"
 )
 
@@ -13,6 +14,9 @@ func ReplyKeyboard(buttons []string) *tb.ReplyMarkup {
 	for _, label := range buttons {
 		buttonsCreated = append(buttonsCreated, kb.Row(kb.Text(label)))
 	}
+	if len(buttonsCreated) > helpers.MAX_REPLY_KEYBOARD_ENTRIES {
+		buttonsCreated = buttonsCreated[:helpers.MAX_REPLY_KEYBOARD_ENTRIES]
+	}
 	kb.Reply(buttonsCreated...)
 	return kb
 }

bot/replyKeyboards_test.go

@@ -0,0 +1,19 @@
+package bot_test
+
+import (
+	"strings"
+	"testing"
+
+	"github.com/LucaBernstein/beancount-bot-tg/bot"
+	"github.com/LucaBernstein/beancount-bot-tg/helpers"
+)
+
+func TestReplyKeyboardMaximumOptions(t *testing.T) {
+	options := []string{"some", "few", "options"}
+	reply := bot.ReplyKeyboard(options)
+	helpers.TestExpect(t, len(reply.ReplyKeyboard), 3, "reply keyboard options count")
+
+	options = strings.Split(strings.Repeat("more_options ", 50), " ")
+	reply = bot.ReplyKeyboard(options)
+	helpers.TestExpect(t, len(reply.ReplyKeyboard), helpers.MAX_REPLY_KEYBOARD_ENTRIES, "reply keyboard options count")
+}

helpers/constants.go

@@ -26,6 +26,8 @@ const (
 	DEFAULT_CURRENCY = "EUR"
 
 	TG_MAX_MSG_CHAR_LEN = 4096
+
+	MAX_REPLY_KEYBOARD_ENTRIES = 40
 )
 
 func AllowedSuggestionTypes() []string {