Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(svelte): 馃幐 add marker & layout props #179

Merged
merged 4 commits into from
Jun 14, 2024

Conversation

theashraf
Copy link
Member

**Changes: **

  • Added marker & layout props to DotLottieSvelte component

Copy link

changeset-bot bot commented Apr 14, 2024

鈿狅笍 No Changeset found

Latest commit: 2076bee

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@theashraf theashraf added enhancement New feature or request svelte labels Apr 14, 2024
Copy link
Contributor

github-actions bot commented Apr 14, 2024

Coverage Report for @lottiefiles/dotlottie-web (packages/web)

Status Category Percentage Covered / Total
馃煝 Lines 87.26% / 87% 281 / 322
馃煝 Statements 83.56% / 83% 295 / 353
馃煝 Functions 85.22% / 84% 75 / 88
馃煝 Branches 76.07% / 76% 194 / 255
File CoverageNo changed files found.
Generated in workflow #1051

Copy link
Contributor

github-actions bot commented Apr 14, 2024

size-limit report 馃摝

Path Size Loading time (3g) Running time (snapdragon) Total time
@lottiefiles/dotlottie-web 12.99 KB (0%) 260 ms (0%) 12 ms (+59% 馃敽) 272 ms
@lottiefiles/dotlottie-web WASM 381.26 KB (0%) 7.7 s (0%) 0 ms (+100% 馃敽) 7.7 s
@lottiefiles/dotlottie-react 16.65 KB (0%) 334 ms (0%) 58 ms (+330.24% 馃敽) 391 ms
@lottiefiles/dotlottie-vue 19.74 KB (0%) 395 ms (0%) 97 ms (+501.59% 馃敽) 491 ms
@lottiefiles/dotlottie-wc 20.77 KB (0%) 416 ms (0%) 71 ms (+116.17% 馃敽) 486 ms
@lottiefiles/dotlottie-svelte 20.7 KB (0%) 414 ms (0%) 92 ms (+761.18% 馃敽) 506 ms

@theashraf theashraf marked this pull request as ready for review April 17, 2024 07:40
Copy link
Collaborator

@afsalz afsalz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 馃殌

@theashraf theashraf merged commit 496db4e into main Jun 14, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request svelte
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants