Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decompile object drawing and missiles #1898

Merged
merged 6 commits into from
Nov 14, 2024
Merged

Decompile object drawing and missiles #1898

merged 6 commits into from
Nov 14, 2024

Conversation

rr-
Copy link
Collaborator

@rr- rr- commented Nov 14, 2024

Checklist

  • I have read the coding conventions
  • I have added a changelog entry about what my pull request accomplishes, or it is an internal change

Description

#1692

Potential regressions should be confined to the following areas:

  • diver harpoons
  • cultist knives
  • dragon breath attack
  • drawing all objects (which use a single generic object drawing routine)
  • drawing pickup sprites (which share a single generic sprite drawing routine)
  • drawing push blocks and doors (which both use the same specific drawing routine)

@rr- rr- added Internal The invisible stuff TR2 labels Nov 14, 2024
@rr- rr- self-assigned this Nov 14, 2024
@rr- rr- requested review from a team as code owners November 14, 2024 09:02
@rr- rr- requested review from lahm86, walkawayy and aredfan and removed request for a team November 14, 2024 09:02
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 14, 2024 •
edited
Loading

Download the built assets for this pull request:

@rr- rr- merged commit 43d4811 into develop Nov 14, 2024
6 of 7 checks passed
@rr- rr- deleted the tr2-decomp branch November 14, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aredfan aredfan aredfan approved these changes

@lahm86 lahm86 lahm86 approved these changes

@walkawayy walkawayy Awaiting requested review from walkawayy walkawayy is a code owner automatically assigned from LostArtefacts/dev

Assignees

@rr- rr-

Labels
Internal The invisible stuff TR2
Projects
Roadmap
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rr- @lahm86 @aredfan