Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

object/names: move name management to libtrx #1545

Closed
wants to merge 4 commits into from
Closed

object/names: move name management to libtrx #1545

wants to merge 4 commits into from

Conversation

rr-
Copy link
Collaborator

@rr- rr- commented Sep 27, 2024 •
edited
Loading

Checklist

  • I have read the coding conventions
  • I have added a changelog entry about what my pull request accomplishes, or it is an internal change

Description

LostArtefacts/libtrx#39

Makes console command targeting to work like in TR2X, so /tp midas in Palace Midas should now work.
Affects all item strings in the inventory – keys, passport etc., and all console commands targeting (/tp wolf etc.).

@rr- rr- added Internal The invisible stuff Enhancement Improvement of an existing feature labels Sep 27, 2024
@rr- rr- added this to the 4.5 milestone Sep 27, 2024
@rr- rr- self-assigned this Sep 27, 2024
@rr- rr- requested review from a team as code owners September 27, 2024 22:09
@rr- rr- requested review from lahm86, walkawayy and aredfan and removed request for a team September 27, 2024 22:09
@rr-
Copy link
Collaborator Author

rr- commented Sep 27, 2024 •
edited
Loading

I've piggybacked two extra fixes to this PR. One resolves the issue with /kill lara not functioning (as it does in TR2), and the other addresses the problem of the console sometimes not registering the initial keypress when typing quickly right after opening it.

aredfan
aredfan approved these changes Sep 28, 2024
View reviewed changes
Copy link
Collaborator

@aredfan aredfan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

I've noticed the unused items now have names, puzzle for machine cog in level 4, and key for the rusty key in level 13. I guess they're more like placeholder names but a nice touch.

@rr-
Copy link
Collaborator Author

rr- commented Sep 29, 2024

Merged manually in 97fd88c.

@rr- rr- closed this Sep 29, 2024
@rr- rr- deleted the libtrx-object-names branch September 29, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aredfan aredfan aredfan approved these changes

@walkawayy walkawayy walkawayy approved these changes

@lahm86 lahm86 lahm86 approved these changes

Assignees

@rr- rr-

Labels
Enhancement Improvement of an existing feature Internal The invisible stuff TR1 TR2
Projects
Roadmap
Archived in project
Milestone
TR1X-4.5
Development

Successfully merging this pull request may close these issues.
4 participants
@rr- @lahm86 @walkawayy @aredfan