Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OSOE-464: Executing dotnet test with process timeout #676

Merged
merged 14 commits into from
Jan 26, 2024
Merged

OSOE-464: Executing dotnet test with process timeout #676

merged 14 commits into from
Jan 26, 2024

Conversation

dministro
Copy link
Member

@dministro
Updating submodule:
708a464 
 - Lombiq.GitHub.Actions: revert, fix test dotnet
@dministro
[no ci]
049cc0c
@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Jan 21, 2024 •
edited
Loading

Warning

Rate Limit Exceeded

@sarahelsaig has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 9 minutes and 25 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.

Commits Files that changed from the base of the PR and between c70aefb and 5f79f26.

Walkthrough

The changes across the workflow and module files indicate a shift towards referencing specific commits for workflow usage and updating parameters related to test execution timeouts. This suggests an effort to enhance the stability and reliability of the testing process by ensuring consistent workflow behavior and managing test run durations more effectively.

Changes

File Path Change Summary
.github/workflows/build-and-test-windows.yml
.github/workflows/build-and-test.yml		 Updated workflow file usage to reference a specific branch (issue/OSOE-464-executing-dotnet-test-with-process-timeout) and adjusted dotnet-test-process-timeout parameter. Replaced blame-hang-timeout with dotnet-test-process-timeout.
tools/Lombiq.GitHub.Actions Updated the subproject commit reference in the tools module.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@dministro
Adjusting timeouts and branch references
51b55d3 
Updating submodule:
 - Lombiq.GitHub.Actions: Adjusting branch references
@dministro
Adjusting test process timeout for test
216120e
@dministro
Updating submodule:
69447f9 
 - Lombiq.GitHub.Actions: Fixing process name
@dministro
Updating submodule:
a5efa56 
 - Lombiq.GitHub.Actions: Saving more details
@dministro
Updating submodule:
67eef6e 
 - Lombiq.GitHub.Actions: Fixing PS analyzer warnings
@dministro
Updating submodule:
3b7c1e8 
 - Lombiq.GitHub.Actions: Fixing PS analyzer warnings again
@dministro
Testing dotnet test process timeout on standard runners
d4c57e3
sarahelsaig
sarahelsaig approved these changes Jan 24, 2024
View reviewed changes
Copy link
Member

@sarahelsaig sarahelsaig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just to clarify, does this PR help with the latest complaints too or just with the FileNotFoundException mentioned before that?

@dministro
Copy link
Member Author

LGTM. Just to clarify, does this PR help with the latest complaints too or just with the FileNotFoundException mentioned before that?

This is only for the latest complaints. I'll investigate the FileNotFoundException under a different PR if necessary.

@sarahelsaig
Copy link
Member

sarahelsaig commented Jan 25, 2024 •
edited
Loading

I see, thanks. I thought the output file name change here was fixing the FileNotFoundException

@github-actions GitHub Actions
Copy link

This pull request has merge conflicts. Please resolve those before requesting a review.

@sarahelsaig
submodule
768bb37
@sarahelsaig
Merge remote-tracking branch 'origin/dev' into issue/OSOE-464-executi…
5f79f26 
…ng-dotnet-test-with-process-timeout

# Conflicts:
#	.github/workflows/build-and-test.yml
@sarahelsaig sarahelsaig merged commit fc06881 into dev Jan 26, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarahelsaig sarahelsaig sarahelsaig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dministro @sarahelsaig @LombiqBot