Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

homebrew: toggle analytics (off by default) #1356

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hraban
Copy link
Contributor

@hraban hraban commented Feb 28, 2025

Is there an easy way to add "test groups" or somehow modularize tests? I wanted to add another test where the setting is explicitly toggled off but it would become a bit messy to have three separate homebrew tests top level

@hraban
Copy link
Contributor Author

hraban commented Mar 17, 2025

@Enzime could I bother you for a review?

@malob
Copy link
Contributor

malob commented Mar 17, 2025

Thanks for adding this. A couple notes:

  • To keep with the convention of this module, could you change name to be analytics as opposed to noAnalytics, and invert the behavior/default accordingly.
  • Could you also update the description to be consistent with the other options, including adding an "implementation note".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants