sibling tags

LlmLaraHub · Apr 15, 2024 · 52827ad · 52827ad
1 parent 252d09f
commit 52827ad
Show file tree

Hide file tree

Showing 8 changed files with 24 additions and 27 deletions.
diff --git a/Modules/TagFunction/app/Contracts/TaggableContract.php b/Modules/TagFunction/app/Contracts/TaggableContract.php
@@ -10,5 +10,5 @@ public function tags(): MorphToMany;
 
     public function addTag(string $tag): void;
 
-    public function siblingTags() : array;
+    public function siblingTags(): array;
 }
diff --git a/Modules/TagFunction/tests/Feature/TagTest.php b/Modules/TagFunction/tests/Feature/TagTest.php
@@ -56,24 +56,23 @@ public function test_sibling_tags()
         $document = Document::factory()->create();
 
         $documentChunk = DocumentChunk::factory()->create([
-            'document_id' => $document->id
+            'document_id' => $document->id,
         ]);
-        
-        $documentChunk->addTag("foobar1");
+
+        $documentChunk->addTag('foobar1');
 
         $documentChunk = DocumentChunk::factory()->create([
-            'document_id' => $document->id
+            'document_id' => $document->id,
         ]);
 
         $this->assertCount(2, $document->refresh()->document_chunks);
-        $documentChunk->addTag("foobar1");
-        $documentChunk->addTag("foobar2");
+        $documentChunk->addTag('foobar1');
+        $documentChunk->addTag('foobar2');
 
         $tags = $document->siblingTags();
 
         $this->assertCount(2, $tags);
 
-        $this->assertTrue(in_array("foobar1", $document->siblingTags()));
+        $this->assertTrue(in_array('foobar1', $document->siblingTags()));
     }
-
 }
diff --git a/app/Domains/Documents/Transformers/PdfTransformer.php b/app/Domains/Documents/Transformers/PdfTransformer.php
@@ -4,7 +4,6 @@
 
 use App\Domains\Collections\CollectionStatusEnum;
 use App\Events\CollectionStatusEvent;
-use App\Jobs\DocumentProcessingCompleteJob;
 use App\Jobs\SummarizeDataJob;
 use App\Jobs\SummarizeDocumentJob;
 use App\Jobs\VectorlizeDataJob;

diff --git a/app/Jobs/ProcessFileJob.php b/app/Jobs/ProcessFileJob.php
@@ -34,7 +34,7 @@ public function handle(): void
             new ParsePdfFileJob($this->document),
         ])
             ->name('Process PDF Document - '.$document->id)
-            ->finally(function (Batch $batch) use ($document) {
+            ->finally(function (Batch $batch) {
             })
             ->allowFailures()
             ->dispatch();

diff --git a/app/Models/Collection.php b/app/Models/Collection.php
@@ -48,7 +48,8 @@ public function getDriver(): string
         return $this->driver->value;
     }
 
-    public function siblingTags() : array {
+    public function siblingTags(): array
+    {
         return [];
     }
 

diff --git a/app/Models/Document.php b/app/Models/Document.php
@@ -34,17 +34,18 @@ class Document extends Model implements HasDrivers, TaggableContract
         'summary_status' => StatusEnum::class,
     ];
 
-    public function siblingTags() : array {
+    public function siblingTags(): array
+    {
         return Tag::query()
-        ->select("tags.name")
-        ->join("taggables", "taggables.tag_id", "=", "tags.id")
-        ->join("document_chunks", "document_chunks.document_id", "=", "taggables.taggable_id")
-        ->where("taggables.taggable_type", "=", DocumentChunk::class)
-        ->where("document_chunks.document_id", "=", $this->id)
-        ->distinct('name')
-        ->get()
-        ->pluck("name")
-        ->toArray();
+            ->select('tags.name')
+            ->join('taggables', 'taggables.tag_id', '=', 'tags.id')
+            ->join('document_chunks', 'document_chunks.document_id', '=', 'taggables.taggable_id')
+            ->where('taggables.taggable_type', '=', DocumentChunk::class)
+            ->where('document_chunks.document_id', '=', $this->id)
+            ->distinct('name')
+            ->get()
+            ->pluck('name')
+            ->toArray();
     }
 
     public function collection(): BelongsTo

diff --git a/app/Models/DocumentChunk.php b/app/Models/DocumentChunk.php
@@ -35,11 +35,11 @@ public function document()
         return $this->belongsTo(Document::class);
     }
 
-    public function siblingTags() : array {
+    public function siblingTags(): array
+    {
         return [];
     }
 
-
     /**
      * The "booted" method of the model.
      *

diff --git a/tests/Feature/Models/DocumentTest.php b/tests/Feature/Models/DocumentTest.php
@@ -2,7 +2,6 @@
 
 namespace Tests\Feature\Models;
 
-use LlmLaraHub\TagFunction\Models\Tag;
 use Tests\TestCase;
 
 class DocumentTest extends TestCase
@@ -19,6 +18,4 @@ public function test_factory(): void
         $this->assertCount(1, $model->collection->documents);
         $this->assertNotNull($model->collection->documents()->first()->id);
     }
-
-
 }