Skip to content

Conversation

SayakaOno
Copy link
Collaborator

@SayakaOno SayakaOno commented Sep 3, 2025

Description

I noticed while upgrading react-router-dom that users could access routes that should be hidden.
This PR:

  • removes /people and /farm for worker accounts (sidebar navs are hidden)
  • comments out /add_task/edit_custom_task_update (this should've been hidden as part of "Comment out route for edit custom task type" ticket)
  • remove unused imports (address Joyce's comment, thank you!! 🙏)

Jira link:

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Passes test case
  • UI components visually reviewed on desktop view
  • UI components visually reviewed on mobile view
  • Other (please explain)

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The precommit and linting ran successfully
  • I have added or updated language tags for text that's part of the UI
  • I have ordered translation keys alphabetically (optional: run pnpm i18n to help with this)
  • I have added the GNU General Public License to all new files

@SayakaOno SayakaOno self-assigned this Sep 3, 2025
@SayakaOno SayakaOno added the bug Something isn't working label Sep 3, 2025
@SayakaOno SayakaOno changed the base branch from LF-4241/Upgrade_to_React_Router_v5.1 to integration September 9, 2025 15:38
@SayakaOno SayakaOno changed the title [WIP] Routes cleanup Routes cleanup Sep 9, 2025
@SayakaOno SayakaOno marked this pull request as ready for review September 9, 2025 17:56
@SayakaOno SayakaOno requested review from a team as code owners September 9, 2025 17:56
@SayakaOno SayakaOno requested review from kathyavini and removed request for a team September 9, 2025 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant