Skip to content

Conversation

navDhammu
Copy link
Collaborator

Description

The start script is using dist/app as for the path to start the backend server. This works for using with docker but fails otherwise, so to keep it consistent I updated the Docker setup to match the local structure. This way the server.js file is always in dist/api/src/server.js.

Tested locally by running the docker container and starting server.js in /dist.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Passes test case
  • UI components visually reviewed on desktop view
  • UI components visually reviewed on mobile view
  • Other (please explain)

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The precommit and linting ran successfully
  • I have added or updated language tags for text that's part of the UI
  • I have ordered translation keys alphabetically (optional: run pnpm i18n to help with this)
  • I have added the GNU General Public License to all new files

@navDhammu navDhammu requested review from a team as code owners June 13, 2025 03:49
@navDhammu navDhammu requested review from kathyavini and removed request for a team June 13, 2025 03:49
Copy link
Collaborator

@Duncan-Brain Duncan-Brain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this change, I feel like there was some hesitancy from someone to do this in our last docker upgrade.

What do you think about changing the whole workdir to match litefarm?

/LiteFarm/api ?

@navDhammu
Copy link
Collaborator Author

@Duncan-Brain I like the idea of changing it to /LiteFarm.

To still keep the convention of source code under usr/src , my preference would be /usr/src/litefarm, vs just /litefarm. But I don't think it matters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants