Lf 4281 migrate current weather api call to backend #3729
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gursimran-singh
requested review from
antsgar and
kathyavini
and removed request for
a team
antsgar
reviewed
Apr 9, 2025
Comment on lines
23
to
29
| try { | ||
| const farm_id = req.headers['farm_id']; | ||
| const row = await baseController.getIndividual(FarmModel, farm_id); | ||
|
|
||
| if (!row.length) { | ||
| return res.sendStatus(404); | ||
| } |
There was a problem hiding this comment.
We have a method called getFarmByID in the farm controller that does exactly this except it gets the farm from the params, could we update that one to read either from params or from the header? I also think that method should probably just return the single row instead of an array
There was a problem hiding this comment.
This function getFarmByID also uses await baseController.getIndividual(FarmModel, id); so the result would be same. I have updated the code to use array de-structure rather than index to make it cleaner.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a new endpoint to provide weather information for the farm. Previously, the frontend directly called the OpenWeather API, exposing API keys. Now, all logic is handled securely behind this endpoint. Additionally, this PR updates the frontend to use the correct RTK Query endpoint for fetching weather data.
Jira link:https://lite-farm.atlassian.net/browse/LF-4281
Type of change
How Has This Been Tested?
Login with your credentials and select farm. On landing page, weather information is shown.
Checklist: