Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1366 disable collapse hide section settings #1564

Closed

Conversation

CTXP
Copy link

@CTXP CTXP commented May 1, 2024

CTXP Medium CTXP /1366-disable-collapse-hide-section-settings → Lissy93/dashy Commits: 2 | Files Changed: 6 | Additions: 28 Label Powered by Pull Request Badge

Thank you for contributing to Dashy! So that your PR can be handled effectively, please populate the following fields (delete sections that are not applicable)

Category:

One of: Bugfix / Feature / Code style update / Refactoring Only / Build related changes / Documentation / Other (please specify)
Feature

Overview

Briefly outline your new changes...
It is now possible to disable the collapse of sections and hide section editing via config options hideCollapse and hideEditing.

Issue Number (if applicable) #00
#1366

New Vars (if applicable)

If you've added any new build scripts, environmental variables, config file options, dependency or devDependency, please outline here
hideCollapse - If set to true, tsections will not be able to collapse
hideEditing - If set to true, sections will no longer have a options icon

Screenshot (if applicable)

If you've introduced any significant UI changes, please include a screenshot

Code Quality Checklist (Please complete)

  • All changes are backwards compatible
  • All lint checks and tests are passing
  • There are no (new) build warnings or errors
  • (If a new config option is added) Attribute is outlined in the schema and documented
  • (If a new dependency is added) Package is essential, and has been checked out for security or performance
  • Bumps version, if new feature added

@CTXP CTXP requested a review from Lissy93 as a code owner May 1, 2024 10:00
Copy link

netlify bot commented May 1, 2024

Deploy Preview for dashy-dev ready!

Name Link
🔨 Latest commit 3136720
🔍 Latest deploy log https://app.netlify.com/sites/dashy-dev/deploys/663212d17bad0a0008ef2547
😎 Deploy Preview https://deploy-preview-1564--dashy-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@CTXP CTXP closed this by deleting the head repository May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant