This repository has been archived by the owner on Feb 17, 2021. It is now read-only.
Adding builders for Objective-C wrappers. #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 8, 2018 16:49
Some minor cleanup of whitespace and duplicated properties.
li-eweng
approved these changes
Mar 9, 2018
renkelvin
approved these changes
Mar 9, 2018
|
|
||
| - (LOKButtonLayout *)build { | ||
| return [[LOKButtonLayout alloc] initWithType:self.type | ||
| title:self.title |
There was a problem hiding this comment.
Should the default values be stated explicitly somewhere?
There was a problem hiding this comment.
Good point, #178 remains open to track the addition of docs and tests for these Objective-C APIs.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.