Getpeername test #377
Getpeername test #377
Conversation
| * use" issues when running them as part of a larger test suite. The purpose of this test | ||
| * is solely to verify that the getpeername function works as expected. Therefore, we | ||
| * opted to use UDS for this test. |
There was a problem hiding this comment.
I'm a little confused. Could you test IPv4, IPv6, and UDS with this test? Why did you only pick one?
| error("Failed to create server thread"); | ||
| } | ||
|
|
||
| sleep(1); |
There was a problem hiding this comment.
Is this supposed to wait long enough for the server thread to complete? Would using locking or signals be better?
| int main() { | ||
| // Just in case this didnt get unlinked last time | ||
| unlink(SERVER_SOCKET_PATH); | ||
| unlink(CLIENT_SOCKET_PATH); |
There was a problem hiding this comment.
suggestion to use semaphores instead of sleep, as it can lead to unstable tests
// Initialize the semaphore if (sem_init(&ready_flag, 0, 0) != 0) { error("Semaphore initialization failed"); }
| } | ||
|
|
||
| sleep(1); | ||
|
|
There was a problem hiding this comment.
waiting for server to be ready
sem_wait(&ready_flag);
| run_client(); | ||
|
|
||
| pthread_join(server_thread, NULL); | ||
|
|
There was a problem hiding this comment.
sem_destroy(&ready_flag);
|
|
||
| printf("Server is listening on %s\n", SERVER_SOCKET_PATH); | ||
| fflush(stdout); | ||
|
|
There was a problem hiding this comment.
sem_post(&ready_flag);
|
|
||
| /* | ||
| * In this test case, we choose to use Unix Domain Sockets (UDS) instead of IPv4/IPv6. | ||
| * While running individual tests with IPv4/IPv6 works fine, we encounter "connection in |
There was a problem hiding this comment.
would port randomization resolve this issue?
|
I agree with the other comments about syncronization. You may want to look at the pthread_barriers we use in some of the other tetsts. |
Description
During the execution of the LAMP stack, it was discovered that the test suite lacked a test case for the getpeername function. This PR aims to add a test case for getpeername to make the test suite more comprehensive. To avoid issues related to "connection in use" that can occur with IPv4/IPv6 in a test suite, Unix Domain Sockets (UDS) are used for this test.
Type of change
Add test
How Has This Been Tested?
make testChecklist: