Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue #19178: The name of the survey disappear from ALL page #3825

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

Shnoulle
Copy link
Collaborator

Dev: start process page by page …

@Shnoulle Shnoulle marked this pull request as draft April 22, 2024 14:22
@Shnoulle
Copy link
Collaborator Author

Need advice / opinion

  1. Use always small for Survey name
  2. Use always d-block for Survey name
  3. Use h2 class

Basic
image

small on survey
image

small + dblock
image

h2 + small + d-block
image

@Shnoulle
Copy link
Collaborator Author

Fixing heading map in same PR
image

@Shnoulle Shnoulle marked this pull request as ready for review April 27, 2024 16:38
@Shnoulle
Copy link
Collaborator Author

Ready for code review

  1. Add title at near all Survey page (some use a specific view)
  2. Review some heading map
  3. Add survey name and id at all page

@c-schmitz
Copy link
Contributor

c-schmitz commented Apr 29, 2024

Oh wow.
Wouldn't it have much more sense to update the breadcrumb to show the name instead of 3 dots? That was what I was always missing. Having the survey name on every page is cluttering the interface, and not a good solution. I don't need the full name of the survey on every page.

But I would also need it in the page title when navigating with several tabs.

@c-schmitz
Copy link
Contributor

c-schmitz commented Apr 29, 2024

Breadcrumb gets too long? Ellipsize it in the middle of each segment , or make space that it can span across the buttons on top.

@Shnoulle
Copy link
Collaborator Author

It's really better to have it on the title of the page.

Know the current survey is a major information inside admin GUI. Not a navigation information.

Breadcrumb are breadcrumb : help on navigation only.
Not “What is the usage of this page”

PS : we can easily put only SID in the new title : it's a widget.

And more : it's restricted now
image

I think

@Shnoulle
Copy link
Collaborator Author

Shnoulle commented Apr 29, 2024

Breadcrumb gets too long? Ellipsize it in the middle of each segment , or make space that it can span across the buttons on top.

My opinion : it's another issue to report : have real breadcrumb (and i think the current one are badly placed)

Maybe we can update title widget when we update breadcrumb

@c-schmitz
Copy link
Contributor

The breadcrumb is not for navgiation only, but also information on where exactly you are right now in the application.
It should reflect the survey name -> groupname -> questionname at all times up to a reasonable length.
It is the THE place where this information needs to be.
I feel it is cluttering the interface by putting it in various locations inside the main content.

I am really sorry. but I wish this would have been discussed before you put in all the coding time.

@Shnoulle
Copy link
Collaborator Author

Shnoulle commented May 2, 2024

I am really sorry. but I wish this would have been discussed before you put in all the coding time.

I put sample here and the screenshot was clear here : https://bugs.limesurvey.org/view.php?id=19178#c77765

The original issue was about page title … , not breadcrumb …

Else : clearly : breadcrumb are done for navigation … page title give more information than bredcrumb on current page.

I can try to review place of breadcrumb, but we need page title. Have a web page without title is a broken usability website.

2 solution:

  • I review this to add update on breadcrumb too (outside of navigation part and more complete), it's easy to remove the Survey title of the website (but i still think it's a good idea to have it).
  • I create another commit for breadcrumb fix (outside of navigation part and more complete)

About breadcrumb

@Shnoulle
Copy link
Collaborator Author

Shnoulle commented May 3, 2024

New issue : 19552: Breadcrumb are badly placed cut and don't show survey name, group name etc …

Else: https://bugs.limesurvey.org/view.php?id=18970#c76212

There is a tooltip if you hover over the 3 dots (...) in the breadcrumbs.

Btw. this is not a bug, if you would like something different, it should be feature request.

ping @tiborpacalat

@tiborpacalat
Copy link
Collaborator

Denis, what action is required here from me?

@Shnoulle
Copy link
Collaborator Author

Denis, what action is required here from me?

More a decision about 19552: Breadcrumb are badly placed cut and don't show survey name, group name etc … mantis issue.

And assignment

@Shnoulle
Copy link
Collaborator Author

Denis, what action is required here from me?

And maybe test survey management UX with or without this title

@Shnoulle
Copy link
Collaborator Author

Breadcrumb gets too long? Ellipsize it in the middle of each segment , or make space that it can span across the buttons on top.

Can we have both ? New title (easy to remove the Survey name, since it was an extension + real and complete breadcrumb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants