Skip to content

Ignore parameters causing ValueError when dumping to YAML #19804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
awaelchli merged 7 commits into from
Jun 6, 2024
Merged

Ignore parameters causing ValueError when dumping to YAML #19804

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
78722ba
Ignore parameters causing ValueError when dumping to YAML
Callidior Apr 23, 2024
1efa728
Update CHANGELOG.md
Callidior Apr 23, 2024
ae7d1c2
Merge branch 'master' into patch-1
Borda May 22, 2024
4423e6b
add test
awaelchli Jun 6, 2024
3bd66a4
update changelog
awaelchli Jun 6, 2024
65eca2b
update test
awaelchli Jun 6, 2024
934f022
Merge branch 'master' into patch-1
awaelchli Jun 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/lightning/pytorch/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).

- Fixed `WandbLogger.log_hyperparameters()` raising an error if hyperparameters are not JSON serializable ([#19769](https://github.com/Lightning-AI/pytorch-lightning/pull/19769))

-
- Fixed ignoring `nn.Module` and `Tensor` parameters when dumping LightningModule parameters to YAML ([#19804](https://github.com/Lightning-AI/pytorch-lightning/pull/19804))


## [2.2.2] - 2024-04-11
Expand Down
2 changes: 1 addition & 1 deletion src/lightning/pytorch/core/saving.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -359,7 +359,7 @@ def save_hparams_to_yaml(config_yaml: _PATH, hparams: Union[dict, Namespace], us
try:
v = v.name if isinstance(v, Enum) else v
yaml.dump(v)
except TypeError:
except (TypeError, ValueError):
warn(f"Skipping '{k}' parameter because it is not possible to safely dump to YAML.")
hparams[k] = type(v).__name__
else:
Expand Down