Repository navigation
fix: pin the third-party WordPress plugins and prorate subscription upgrades - #28
Merged
Merged
Conversation
Signed-off-by: YvesCesar <yvesamorim73@gmail.com>
Signed-off-by: YvesCesar <yvesamorim73@gmail.com>
fix: prorate subscription upgrades in the local and e2e stores
Signed-off-by: YvesCesar <yvesamorim73@gmail.com>
Signed-off-by: YvesCesar <yvesamorim73@gmail.com>
…d-party plugins Signed-off-by: YvesCesar <yvesamorim73@gmail.com>
Signed-off-by: YvesCesar <yvesamorim73@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Third-party plugins pinned to a commit
Polylang Pro and WooCommerce Subscriptions are cloned from third-party mirrors (
gitlab.com/wordpress-premium/polylang-proandpronamic/woocommerce-subscriptions), so every start of the local and E2E stores ran whatever those mirrors had at the time. Theirpost_install_commandsnow check out a fixed commit, the release each mirror's default branch points to today (Polylang Pro 3.7.6, WooCommerce Subscriptions 9.4.1).The command fetches only when the plugin is not already at that commit, so restarts work offline. If the fetch fails, it prints a warning and keeps the current commit instead of failing: the
wordpress-dockerentrypoint runs withset -e, so a failing command would stop it before PHP-FPM starts and leave the container restarting.Each pin line carries the release tag, the commit and the mirror URL.
.github/renovate.json5enables onlycustom.regex(Dependabot keeps the submodules, npm, Compose images and Actions) and follows the mirrors' tags with thegit-tagsdatasource, so a new release becomes a PR that bumps the tag and the commit together, on Mondays.The site, the Nextcloud apps and the LibreSign WordPress plugins and theme keep following
main, since they only change through reviewed PRs. The README says which components are pinned and how they are updated.Prorated subscription upgrades (#29)
The local and E2E stores now set
woocommerce_subscriptions_apportion_recurring_pricetoyes-upgrade, as in production, and the plan change E2E test checks the prorated order total.Verification
wordpress-dockerentrypoint functions inside the published image, withset -e: it checks out the pinned commit, does nothing when already there with the remote unreachable, and warns and keeps the current commit when the fetch fails, reaching the PHP-FPM start in every case.renovate-config-validatoraccepts the config.renovate --platform=local --dry-run=lookup, with Polylang Pro set back tov3.7.3, proposesv3.7.6with its commit, and reports WooCommerce Subscriptions as up to date.make test-configpasses.The Renovate app needs access to this repository for the PRs to be opened.