Lesson_5 #1189
Open
Lesson_5 #1189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Константин, добрый день |
Liberate520
reviewed
Aug 27, 2024
| public FamilyTree<Human> getFamilyTree(){ | ||
| return tree; | ||
| } | ||
|
|
There was a problem hiding this comment.
добавьте методы сохранения и загрузки
| @@ -0,0 +1,6 @@ | |||
| package family_tree.view; | |||
There was a problem hiding this comment.
Непонятно. Уточните свою работу с гитом. Так как в гите файл находится в пакете commands, а в файле написано, что пакет называется view.
Добавлены классы Parent, Child, Human
Liberate520
reviewed
Aug 29, 2024
| public class Presenter { | ||
| private View view; | ||
| private Service service; | ||
| private FileManager fileManager; |
There was a problem hiding this comment.
сервисный класс должен управлять файловым менеджером, а не презентер
There was a problem hiding this comment.
Прямая зависимость нарушает пятый принцип солид
|
|
||
| public void saveToFile() { | ||
| String filename; | ||
| String filePath = "src/model/writer/"; |
There was a problem hiding this comment.
Путь к файлу должен быть в FileHandler, а не во view
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.