FamilyTreeHomeWork #1180
Open
FamilyTreeHomeWork #1180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Liberate520
reviewed
Aug 23, 2024
| } | ||
|
|
||
| public void sortByAge(){ | ||
| Collections.sort(humans, new ComparatorByAge()); |
There was a problem hiding this comment.
при создании объектов обобщенного типа стоит добавлять угловые скобочки
Liberate520
reviewed
Aug 27, 2024
| public boolean addChild(int parentId, int childId){ | ||
| return service.addChild(parentId, childId); | ||
| } | ||
|
|
There was a problem hiding this comment.
добавьте методы сохранения и загрузки
Liberate520
reviewed
Aug 29, 2024
| private int idHuman; | ||
| private FamilyTree<Human> tree; | ||
| private HumanBuilder humanBuilder; | ||
| FileHandler fileHandler; |
There was a problem hiding this comment.
прямая зависимость нарушает пятый принцип солид
Liberate520
reviewed
Sep 2, 2024
| import family_tree.model.human.Human; | ||
|
|
||
| public class FileManager { | ||
| private FileHandler fileHandler; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.