Hw5 #1172
Open
Hw5 #1172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Liberate520
reviewed
Aug 10, 2024
src/model/human/HumanBuilder.java
Outdated
| import java.util.ArrayList; | ||
| import java.util.List; | ||
|
|
||
| public class HumanBuilder<E extends FamilyTreeItem<E>> { |
There was a problem hiding this comment.
В чем смысл обобщения, если класс ничего кроме Human все равно никогда не создаст?
src/model/family_tree/Service.java
Outdated
|
|
||
| import java.time.LocalDate; | ||
|
|
||
| public class Service<E extends FamilyTreeItem<E>>{ |
There was a problem hiding this comment.
обобщение можно убрать. Сервис должен быть именно для работы с людьми
src/presenter/Presenter.java
Outdated
| switch (choice){ | ||
| case "1": | ||
| String sChild, sParent; | ||
| System.out.println("Введите имя родителя"); |
There was a problem hiding this comment.
презентер не должен выводить текст в консоль. за работу с консолью отвечает view
src/presenter/Presenter.java
Outdated
| } | ||
|
|
||
| public boolean addParent(String choice){ | ||
| Scanner scanner = new Scanner(System.in); |
There was a problem hiding this comment.
презентер не должен работать со сканером. За общение с пользователем отвечает view
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.