Застрял на добавлении детей в список экземпляра класса. #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Liberate520
reviewed
Apr 1, 2024
src/ru/gb/FamilyTree/FamilyTree.java
Outdated
| import java.util.List; | ||
|
|
||
| public class FamilyTree { | ||
| List<Human> list; |
There was a problem hiding this comment.
поля класса почти всегда приватны
src/ru/gb/FamilyTree/Main.java
Outdated
|
|
||
|
|
||
| FamilyTree familyTree = new FamilyTree(); | ||
| familyTree.list = new ArrayList<>(); |
There was a problem hiding this comment.
А было бы поле приватно и такая строчка была бы невозможной. В данном случае вы нарушаете инкапсуляцию. Только класс должен решать как ему использовать свои поле. Извне это должно быть невозможно
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Не получается добавить детей экземпляру класса.
Работает только если не выводить в терминал метод ToString.