Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

builder: support building Date object #510

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

builder: support building Date object #510

wants to merge 1 commit into from

Conversation

peat-psuwit
Copy link

Xml2Js is made to support outputting Date object as XML's dateTime,
which is an ISO8601 format string. So, Date's toISOString() is used.

P.S.: I'm not sure how to document this, so no documentation is given.

@peat-psuwit
builder: support building Date object
55b032e 
Xml2Js is made to support outputting Date object as XML's dateTime,
which is an ISO8601 format string. So, Date's toISOString() is used.
@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 97.647% when pulling 55b032e on peat-psuwit:support-building-date into 0f0a298 on Leonidas-from-XIV:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 97.647% when pulling 55b032e on peat-psuwit:support-building-date into 0f0a298 on Leonidas-from-XIV:master.

@piyush-ramavat
Copy link

Any idea when this change will be merged?
Date handling is a must have in XML parser.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piyush-ramavat piyush-ramavat piyush-ramavat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@peat-psuwit @coveralls @piyush-ramavat