Improve roundtrip for some combinations of parser options #461
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem I was trying to solve was to parse some XML data, modify it and encode it back, preserving the order of the XML elements.
The parser have options for that (
preserveChildrenOrder
), but the builder is not able to follow the new structure.The PR addresses the object structure, addresses the cases where the
explicitChildren
orpreserveChildrenOrder
options are set. Two new test cases have been added for them.This is done not relying in additional builder options. This way the parser can accept objects produced by parsers with different options.
I've also refactored slightly the builder loop making these metadata keys (
$
,$$
,_
) addressed before going into the key loop (allowing to take the decision of not looking into the remaining redundant keys)