forked from nophead/Skeinforge50plus
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
now with improved brim with convex=true #2
Open
indazoo
wants to merge
11
commits into
Lenbok:master
Choose a base branch
from
indazoo:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now base layers of skirt and brim are merged meaning a brim value does not push the skirt away from the object. Also skirt and brim can be independent activated/used. No need to change Skirt values when using just the brim.
convex option softened for brim
The plugin "dimension" inserted a extrusion of filament at first M101 before any movement. This is not noticeable with low "Retraction Distance" but with higher values a considerable amount of filament is being extruded. Even worse, if plugin "Alteration" inserted start gcode which moves the head over the plate to prevent oozing during nozzle heating the melting chamber is under pressure at start and creates a nice fat blob and/or fat lines at start. The retraction code should not extrude at start. This is the task of another plugin.
changed also dimension plugin so it does not undo a retraction which did not happen |
- new style classes
joris plugin for vases etc added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brim is now non-convex as long as it does not interfere with skirt